AbstractListCommand

Complexity

Total Complexity

7

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	1

7 Methods

Rating	Name	Duplication	Size	Complexity
A	fire()	0	4	1
	getClassName()	0	1	?
A	getTableData()	0	19	2
A	getTableHeaders()	0	4	1
A	getExtensions()	0	4	1
A	getModule()	0	10	1
A	getParentClasses()	0	4	1

<?php


abstract class AbstractListCommand extends SilverstripeCommand

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public function fire()
    {
        $this->table($this->getTableHeaders(), $this->getTableData());
    }

    abstract function getClassName();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

It is generally recommended to explicitly declare the visibility for methods.

    /**
     * @return array
     */
    protected function getTableData()
    {
        $classes = ClassInfo::subclassesFor($this->getClassName());

        unset($classes[$this->getClassName()]);

        foreach ($classes as $key => $class) {

The expression $classes of type null|array is not guaranteed to be traversable. How about adding an additional type check?

            $classes[$class] = [
                $class,
                implode("\n", (array) $this->getExtensions($class)),
                implode(" => ", (array) $this->getParentClasses($class)),
                $this->getModule($class),
            ];
        }

        ksort($classes);

        return $classes;
    }


    /**
     * @return array
     */
    protected function getTableHeaders()
    {
        return ['ClassName', 'Extensions', 'Extends', 'Module'];
    }

    /**
     * @param $className
     * @return array
     */
    protected function getExtensions($className)
    {
        return (array)Config::inst()->get($className, 'extensions', Config::UNINHERITED);
    }

    /**
     * @param string $className
     * @return string
     */
    protected function getModule($className)
    {
        $reflection = new \ReflectionClass($className);
        $file = $reflection->getFileName();

        $path  = str_replace([BASE_PATH.'/'], '', $file);
        $parts = explode(DIRECTORY_SEPARATOR, $path);

        return (string)array_shift($parts);
    }

    /**
     * @param string $className
     * @return array
     */
    protected function getParentClasses($className)
    {
        return ClassInfo::ancestry($className);
    }
}