Code Duplication - axyr/silverstripe-console - Measure and Improve Code Quality continuously with Scrutinizer

Code Duplication Length = 28-30 lines in 2 locations

code/Commands/List/ListControllerCommand.php 1 location


<?php


class ListControllerCommand extends AbstractListCommand
{
    /**
     * @var string
     */
    protected $signature = 'list:controller';

    /**
     * @var string
     */
    protected $description = 'List all subclasses of Controller';

    public function getClassName()
    {
        return 'Controller';
    }

    /**
     * @param $className
     * @return array
     */
    protected function getParentClasses($className)
    {
        // removes $className and Controller => RequestHandler => ViewableData => Object
        $parentClasses = array_slice(parent::getParentClasses($className), 4, -1);
        return array_reverse($parentClasses);
    }
}


code/Commands/List/ListDataObjectCommand.php 1 location


<?php


class ListDataObjectCommand extends AbstractListCommand
{
    /**
     * @var string
     */
    protected $signature = 'list:dataobject';

    /**
     * @var string
     */
    protected $description = 'List all subclasses of DataObject';

    /**
     * @return string
     */
    public function getClassName()
    {
        return 'DataObject';
    }

    /**
     * @param string $className
     * @return array
     */
    public function getParentClasses($className)
    {
        $parentClasses = array_slice(parent::getParentClasses($className), 3, -1);
        return array_reverse($parentClasses);
    }
}


		@@ 4-31 (lines=28) @@
1		<?php
2
3
4		class ListControllerCommand extends AbstractListCommand
5		{
6		/**
7		* @var string
8		*/
9		protected $signature = 'list:controller';
10
11		/**
12		* @var string
13		*/
14		protected $description = 'List all subclasses of Controller';
15
16		public function getClassName()
17		{
18		return 'Controller';
19		}
20
21		/**
22		* @param $className
23		* @return array
24		*/
25		protected function getParentClasses($className)
26		{
27		// removes $className and Controller => RequestHandler => ViewableData => Object
28		$parentClasses = array_slice(parent::getParentClasses($className), 4, -1);
29		return array_reverse($parentClasses);
30		}
31		}
32

		@@ 4-33 (lines=30) @@
1		<?php
2
3
4		class ListDataObjectCommand extends AbstractListCommand
5		{
6		/**
7		* @var string
8		*/
9		protected $signature = 'list:dataobject';
10
11		/**
12		* @var string
13		*/
14		protected $description = 'List all subclasses of DataObject';
15
16		/**
17		* @return string
18		*/
19		public function getClassName()
20		{
21		return 'DataObject';
22		}
23
24		/**
25		* @param string $className
26		* @return array
27		*/
28		public function getParentClasses($className)
29		{
30		$parentClasses = array_slice(parent::getParentClasses($className), 3, -1);
31		return array_reverse($parentClasses);
32		}
33		}
34

axyr / silverstripe-console

Code Duplication Length = 28-30 lines in 2 locations

code/Commands/List/ListControllerCommand.php 1 location

code/Commands/List/ListDataObjectCommand.php 1 location