MakeFormCommand

Complexity

Total Complexity

14

Size/Duplication

Total Lines	108
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	4
Bugs	1	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	writeFile()	0	19	3
A	addFormMethodToController()	0	12	3
A	addAllowedActionsToController()	0	9	2
A	findControllerFilePath()	0	14	3
A	getFormMethodStub()	0	8	2
A	getOptions()	0	8	1

<?php


use Symfony\Component\Console\Input\InputOption;

class MakeFormCommand extends AbstractMakeCommand

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var string
     */
    protected $name = 'make:form';

    /**
     * @var string
     */
    protected $description = 'Create a new Form class and optional template';

    protected function writeFile($target, $class)
    {
        parent::writeFile($target, $class);

        if ($controller = $this->option('controller')) {
            $filePath = $this->findControllerFilePath($controller);
            if ($filePath !== false) {
                $this->addFormMethodToController($controller, $class);

It seems like $controller defined by $this->option('controller') on line 22 can also be of type array; however, MakeFormCommand::addFormMethodToController() does only seem to accept string, maybe add an additional type check?

                $content = file_get_contents($filePath);

                $content = $this->addFormMethodToController($content, $class);
                $this->info($class.' method added to ', $controller);

It seems like $controller defined by $this->option('controller') on line 22 can also be of type array; however, SilverstripeCommand::info() does only seem to accept null|integer|string, maybe add an additional type check?

                $content = $this->addAllowedActionsToController($content, $class);
                $this->warn('Adding allowed_actions not supported yet');

                file_put_contents($filePath, $content);
            }
        }
    }

    /**
     * @param string $content
     * @param string $formClass
     *
     * @return string
     */
    protected function addFormMethodToController($content, $formClass)
    {
        if (!Str::contains($content, "function $formClass(")) {
            $methodStub = $this->getFormMethodStub($formClass);
            $replacement = $methodStub."\n}";
            if ($methodStub) {

The expression $methodStub of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

                $content = Str::replaceLast('}', $replacement, $content);
            }
        }

        return $content;
    }

    /**
     * @param string $content
     * @param string $formClass
     *
     * @return string
     */
    protected function addAllowedActionsToController($content, $formClass)

The parameter $formClass is not used and could be removed.

    {
        $allowedActions = 'private static $allowed_actions';

        if (!Str::contains($content, $allowedActions)) {

This if statement is empty and can be removed.

        }

        return $content;
    }

    /**
     * @param $controller
     *
     * @return bool|string
     */
    protected function findControllerFilePath($controller)
    {
        $controller = strtolower($controller);
        $classes = SS_ClassLoader::instance()->getManifest()->getClasses();
        $filePath = isset($classes[$controller]) ? $classes[$controller] : '';

        if (!is_file($filePath)) {
            $this->error("$filePath does not exist");

            return false;
        }

        return $filePath;
    }

    protected function getFormMethodStub($formClass)
    {
        $file = $this->getStubFilePath('ControllerFormMethods');

        if (is_file($file)) {
            return str_replace('DummyClass', $formClass, file_get_contents($file));
        }
    }

    /**
     * @return array
     */
    protected function getOptions()
    {
        $options = parent::getOptions();
        $options[] = ['template', 't', InputOption::VALUE_NONE, 'Create a custom template for this Form'];
        $options[] = ['controller', 'C', InputOption::VALUE_REQUIRED, 'Add FormMethod and allowed actions to the given Controller'];

        return $options;
    }
}