ListRouteCommand

Complexity

Total Complexity

12

Size/Duplication

Total Lines	91
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	4
Bugs	1	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	fire()	0	6	1
A	routes()	0	18	3
A	getActionsForController()	0	12	3
A	getUrlHandlersForController()	0	12	3
A	getValuesOrKeysFromConfig()	0	10	2

<?php

class ListRouteCommand extends SilverstripeCommand

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var string
     */
    protected $signature = 'list:route';

    /**
     * @var string
     */
    protected $description = 'List all routes to Controllers';

    public function fire()
    {
        $headers = ['Route', 'Controller', 'Allowed Actions'];

        $this->table($headers, $this->routes());
    }

    public function routes()
    {
        $routes = Config::inst()->get('Director', 'rules');

        $list = [];

        foreach ($routes as $route => $controller) {

The expression $routes of type array|integer|double|string|boolean is not guaranteed to be traversable. How about adding an additional type check?

            $handlers = $this->getUrlHandlersForController($controller);

            $actions = $handlers ? $handlers : $this->getActionsForController($controller);

            $list[$route] = [$route, $controller, implode("\n", $actions)];
        }

        ksort($list);

        return $list;
    }

    /**
     * @param string $controller
     *
     * @return array
     */
    protected function getActionsForController($controller)
    {
        $actions = (array) $this->getValuesOrKeysFromConfig($controller, 'allowed_actions');

        foreach ($actions as $key => $action) {
            if ($action == 'index') {
                unset($actions[$key]);
            }
        }

        return $actions;
    }

    /**
     * @param string $controller
     *
     * @return array
     */
    protected function getUrlHandlersForController($controller)
    {
        $handlers = (array) $this->getValuesOrKeysFromConfig($controller, 'url_handlers');

        foreach ($handlers as $key => $handler) {
            if ($handler == '') {
                unset($handlers[$key]);
            }
        }

        return $handlers;
    }

    /**
     * @param string $controller
     * @param string $config
     *
     * @return array
     */
    protected function getValuesOrKeysFromConfig($controller, $config = 'allowed_actions')
    {
        $values = (array) Config::inst()->get($controller, $config, Config::UNINHERITED);

        if (!isset($values[0])) { // assoc with permissions set as values
            $values = array_keys($values);
        }

        return $values;
    }
}