Issues in AdminSecurity.php (master) - Issues in master - axyr/silverstripe-adminlogin - Measure and Improve Code Quality continuously with Scrutinizer

Issues (10)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/AdminSecurity.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


/**
 * Class AdminSecurity.
 */
class AdminSecurity extends Security
namespace YourVendor;

class YourClass { }
{
    /**
     * @var array
     */
    private static $allowed_actions = [

        'passwordsent',
        'ChangePasswordForm',
    ];

    /**
     * Template thats used to render the pages.
     *
     * @config
     *
     * @var string
     */
    private static $template_main = 'AdminLogin';


    /**
     * @return void
     */
    public function init()
    {
        parent::init();

        $access = new IpAccess($this->getRequest()->getIP());
        if (!$access->hasAccess()) {
            $access->respondNoAccess($this);
        }

        if (Config::inst()->get('AdminLogin', 'UseTheme') !== true) {
            // this prevents loading frontend css and javscript files
            Object::useCustomClass('Page_Controller', 'AdminLoginPage_Controller');
            Requirements::css('adminlogin/css/style.css');
        }

        Object::useCustomClass('MemberLoginForm', 'AdminLoginForm');
    }

    /**
     * @param null $action
     *
     * @return string
     */
    public function Link($action = null)
    {
        return "AdminSecurity/$action";
    }

    /**
     * @return string
     */
    public static function isAdminLogin()
    {
        return strstr(self::getBackUrl(), '/admin/');
    }

    /**
     * @return string
     */
    public static function getBackUrl()
    {
        $request = Controller::curr()->getRequest();
        if ($url = $request->requestVar('BackURL')) {
            return $url;
        }

        return '';
    }

    /**
     * @param SS_HTTPRequest $request
     *
     * @return SS_HTTPResponse|HTMLText
     */
    public function passwordsent($request)
    {
        return parent::passwordsent($request);
    }

    /**
     * @see Security::getPasswordResetLink()
     * We overload this, so we can add the BackURL to the password resetlink
     *
     * @param Member $member
     * @param string $autologinToken
     *
     * @return string
     */
    public static function getPasswordResetLink($member, $autologinToken)
    {
        $autologinToken = urldecode($autologinToken);
        $selfControllerClass = __CLASS__;
        $selfController = new $selfControllerClass();

        return $selfController->Link('changepassword')."?m={$member->ID}&t=$autologinToken";
    }

    /**
     * @return ChangePasswordForm
     */
    public function ChangePasswordForm()
    {
        return new ChangePasswordForm($this, 'ChangePasswordForm');
    }
}


1			<?php
2
3
4			/**
5			* Class AdminSecurity.
6			*/
7			class AdminSecurity extends Security
			0 ignored issues – show Coding Style Compatibility introduced 2016-04-13 20:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
8			{
9			/**
10			* @var array
11			*/
12			private static $allowed_actions = [
			0 ignored issues – show Comprehensibility introduced 2016-04-13 20:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-04-13 20:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$allowed_actions` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
13			'passwordsent',
14			'ChangePasswordForm',
15			];
16
17			/**
18			* Template thats used to render the pages.
19			*
20			* @config
21			*
22			* @var string
23			*/
24			private static $template_main = 'AdminLogin';
			0 ignored issues – show Comprehensibility introduced 2016-04-13 20:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-04-13 20:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$template_main` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
25
26			/**
27			* @return void
28			*/
29			public function init()
30			{
31			parent::init();
32
33			$access = new IpAccess($this->getRequest()->getIP());
34			if (!$access->hasAccess()) {
35			$access->respondNoAccess($this);
36			}
37
38			if (Config::inst()->get('AdminLogin', 'UseTheme') !== true) {
39			// this prevents loading frontend css and javscript files
40			Object::useCustomClass('Page_Controller', 'AdminLoginPage_Controller');
41			Requirements::css('adminlogin/css/style.css');
42			}
43
44			Object::useCustomClass('MemberLoginForm', 'AdminLoginForm');
45			}
46
47			/**
48			* @param null $action
49			*
50			* @return string
51			*/
52			public function Link($action = null)
53			{
54			return "AdminSecurity/$action";
55			}
56
57			/**
58			* @return string
59			*/
60			public static function isAdminLogin()
61			{
62			return strstr(self::getBackUrl(), '/admin/');
63			}
64
65			/**
66			* @return string
67			*/
68			public static function getBackUrl()
69			{
70			$request = Controller::curr()->getRequest();
71			if ($url = $request->requestVar('BackURL')) {
72			return $url;
73			}
74
75			return '';
76			}
77
78			/**
79			* @param SS_HTTPRequest $request
80			*
81			* @return SS_HTTPResponse\|HTMLText
82			*/
83			public function passwordsent($request)
84			{
85			return parent::passwordsent($request);
86			}
87
88			/**
89			* @see Security::getPasswordResetLink()
90			* We overload this, so we can add the BackURL to the password resetlink
91			*
92			* @param Member $member
93			* @param string $autologinToken
94			*
95			* @return string
96			*/
97			public static function getPasswordResetLink($member, $autologinToken)
98			{
99			$autologinToken = urldecode($autologinToken);
100			$selfControllerClass = __CLASS__;
101			$selfController = new $selfControllerClass();
102
103			return $selfController->Link('changepassword')."?m={$member->ID}&t=$autologinToken";
104			}
105
106			/**
107			* @return ChangePasswordForm
108			*/
109			public function ChangePasswordForm()
110			{
111			return new ChangePasswordForm($this, 'ChangePasswordForm');
112			}
113			}
114

axyr / silverstripe-adminlogin

Issues (10)

Security Analysis not enabled

code/AdminSecurity.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like