HasComments::comment() - Code Metrics - axitdev/LaravelFastComments - Measure and Improve Code Quality continuously with Scrutinizer

HasComments::comment() A
last analyzed 2019-05-15 03:14 UTC

↳ Parent: HasComments

Complexity

Conditions	2
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	2
nc	1
nop	2

<?php

namespace Axitdev\LaravelFastComments\Traits;

use Axitdev\LaravelFastComments\LaravelFastComments;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\MorphMany;

trait HasComments
{
    /**
     * Return all comments for model
     *
     * @return MorphMany
     */
    public function comments()
    {
        return $this->morphMany(LaravelFastComments::class, 'commentable');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param string $comment
     * @param Model|null $user
     * @return false|Model
     */
    public function comment(string $comment, ?Model $user = null)
    {
        $comment = new LaravelFastComments([
            'user_id' => is_null($user) ? auth()->user()->id : $user->id,
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'comment' => $comment,
            'commentable_id' => $this->getKey(),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            'commentable_type' => get_class(),
        ]);

        return $this->comments()->save($comment);
    }


}

1			<?php
2
3			namespace Axitdev\LaravelFastComments\Traits;
4
5			use Axitdev\LaravelFastComments\LaravelFastComments;
6			use Illuminate\Database\Eloquent\Model;
7			use Illuminate\Database\Eloquent\Relations\MorphMany;
8
9			trait HasComments
10			{
11			/**
12			* Return all comments for model
13			*
14			* @return MorphMany
15			*/
16			public function comments()
17			{
18			return $this->morphMany(LaravelFastComments::class, 'commentable');
			0 ignored issues – show Bug introduced 2019-05-15 02:50 UTC by Report Bug Copy Issue Report It seems like `morphMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19			}
20
21			/**
22			* @param string $comment
23			* @param Model\|null $user
24			* @return false\|Model
25			*/
26			public function comment(string $comment, ?Model $user = null)
27			{
28			$comment = new LaravelFastComments([
29			'user_id' => is_null($user) ? auth()->user()->id : $user->id,
			0 ignored issues – show Bug introduced 2019-05-15 02:50 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
30			'comment' => $comment,
31			'commentable_id' => $this->getKey(),
			0 ignored issues – show Bug introduced 2019-05-15 02:50 UTC by Report Bug Copy Issue Report It seems like `getKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32			'commentable_type' => get_class(),
33			]);
34
35			return $this->comments()->save($comment);
36			}
37
38
39			}

axitdev / LaravelFastComments

HasComments::comment() A last analyzed 2019-05-15 03:14 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

HasComments::comment() A
last analyzed 2019-05-15 03:14 UTC