CreateUserCommand::interact() - Code Metrics - Inspection of "Added Admin section" - awurth/Slim - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ad54cf...a5bc07 )

by Alexis

created 2017-10-14 15:13 UTC

CreateUserCommand::interact() C

↳ Parent: CreateUserCommand

Complexity

Conditions	8
Paths	16

Size

Total Lines	48
Code Lines	27

Duplication

Lines	36
Ratio	75 %

Importance

Changes

Metric	Value
dl	36
loc	48
rs	5.9322
c	0
b	0
f	0
cc	8
eloc	27
nc	16
nop	2

<?php

namespace App\Command;

use Cartalyst\Sentinel\Sentinel;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\Question;

class CreateUserCommand extends Command
{
    /**
     * @var Sentinel
     */
    private $sentinel;

    /**
     * Constructor.
     *
     * @param Sentinel $sentinel
     */
    public function __construct(Sentinel $sentinel)
    {
        parent::__construct();

        $this->sentinel = $sentinel;
    }

    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this
            ->setName('user:create')
            ->setDescription('Create new user')
            ->setDefinition([
                new InputArgument('username', InputArgument::REQUIRED, 'The username'),
                new InputArgument('email', InputArgument::REQUIRED, 'The email'),
                new InputArgument('password', InputArgument::REQUIRED, 'The password'),
                new InputOption('admin', null, InputOption::VALUE_NONE, 'Set the user as admin')
            ]);
    }

    /**
     * {@inheritdoc}
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $username = $input->getArgument('username');
        $email = $input->getArgument('email');
        $password = $input->getArgument('password');
        $admin = $input->getOption('admin');

        if ($admin) {
            $role = $this->sentinel->findRoleByName('Admin');
        } else {
            $role = $this->sentinel->findRoleByName('User');
        }

        $user = $this->sentinel->registerAndActivate([
            'username' => $username,
            'email' => $email,
            'password' => $password,
            'permissions' => [
                'user.delete' => 0
            ]
        ]);

        $role->users()->attach($user);

        return 0;
    }

    /**
     * {@inheritdoc}
     */
    protected function interact(InputInterface $input, OutputInterface $output)
    {
        $questions = [];

        if (!$input->getArgument('username')) {

            $question = new Question('Please choose a username:');
            $question->setValidator(function ($username) {
                if (empty($username)) {
                    throw new \Exception('Username can not be empty');
                }

                return $username;
            });
            $questions['username'] = $question;
        }

        if (!$input->getArgument('email')) {

            $question = new Question('Please choose an email:');
            $question->setValidator(function ($email) {
                if (empty($email)) {
                    throw new \Exception('Email can not be empty');
                }

                return $email;
            });

            $questions['email'] = $question;
        }

        if (!$input->getArgument('password')) {

            $question = new Question('Please choose a password:');
            $question->setValidator(function ($password) {
                if (empty($password)) {
                    throw new \Exception('Password can not be empty');
                }

                return $password;
            });

            $question->setHidden(true);
            $questions['password'] = $question;
        }

        foreach ($questions as $name => $question) {
            $answer = $this->getHelper('question')->ask($input, $output, $question);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $input->setArgument($name, $answer);
        }
    }
}


1		<?php
2
3		namespace App\Command;
4
5		use Cartalyst\Sentinel\Sentinel;
6		use Symfony\Component\Console\Command\Command;
7		use Symfony\Component\Console\Input\InputArgument;
8		use Symfony\Component\Console\Input\InputInterface;
9		use Symfony\Component\Console\Input\InputOption;
10		use Symfony\Component\Console\Output\OutputInterface;
11		use Symfony\Component\Console\Question\Question;
12
13		class CreateUserCommand extends Command
14		{
15		/**
16		* @var Sentinel
17		*/
18		private $sentinel;
19
20		/**
21		* Constructor.
22		*
23		* @param Sentinel $sentinel
24		*/
25		public function __construct(Sentinel $sentinel)
26		{
27		parent::__construct();
28
29		$this->sentinel = $sentinel;
30		}
31
32		/**
33		* {@inheritdoc}
34		*/
35		protected function configure()
36		{
37		$this
38		->setName('user:create')
39		->setDescription('Create new user')
40		->setDefinition([
41		new InputArgument('username', InputArgument::REQUIRED, 'The username'),
42		new InputArgument('email', InputArgument::REQUIRED, 'The email'),
43		new InputArgument('password', InputArgument::REQUIRED, 'The password'),
44		new InputOption('admin', null, InputOption::VALUE_NONE, 'Set the user as admin')
45		]);
46		}
47
48		/**
49		* {@inheritdoc}
50		*/
51		protected function execute(InputInterface $input, OutputInterface $output)
52		{
53		$username = $input->getArgument('username');
54		$email = $input->getArgument('email');
55		$password = $input->getArgument('password');
56		$admin = $input->getOption('admin');
57
58		if ($admin) {
59		$role = $this->sentinel->findRoleByName('Admin');
60		} else {
61		$role = $this->sentinel->findRoleByName('User');
62		}
63
64		$user = $this->sentinel->registerAndActivate([
65		'username' => $username,
66		'email' => $email,
67		'password' => $password,
68		'permissions' => [
69		'user.delete' => 0
70		]
71		]);
72
73		$role->users()->attach($user);
74
75		return 0;
76		}
77
78		/**
79		* {@inheritdoc}
80		*/
81		protected function interact(InputInterface $input, OutputInterface $output)
82		{
83		$questions = [];
84
85	View Code Duplication	if (!$input->getArgument('username')) {
		0 ignored issues – show Duplication introduced 2017-10-14 15:14 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
86		$question = new Question('Please choose a username:');
87		$question->setValidator(function ($username) {
88		if (empty($username)) {
89		throw new \Exception('Username can not be empty');
90		}
91
92		return $username;
93		});
94		$questions['username'] = $question;
95		}
96
97	View Code Duplication	if (!$input->getArgument('email')) {
		0 ignored issues – show Duplication introduced 2017-10-14 15:14 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
98		$question = new Question('Please choose an email:');
99		$question->setValidator(function ($email) {
100		if (empty($email)) {
101		throw new \Exception('Email can not be empty');
102		}
103
104		return $email;
105		});
106
107		$questions['email'] = $question;
108		}
109
110	View Code Duplication	if (!$input->getArgument('password')) {
		0 ignored issues – show Duplication introduced 2017-10-14 15:14 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
111		$question = new Question('Please choose a password:');
112		$question->setValidator(function ($password) {
113		if (empty($password)) {
114		throw new \Exception('Password can not be empty');
115		}
116
117		return $password;
118		});
119
120		$question->setHidden(true);
121		$questions['password'] = $question;
122		}
123
124		foreach ($questions as $name => $question) {
125		$answer = $this->getHelper('question')->ask($input, $output, $question);
		0 ignored issues – show Bug introduced 2017-10-14 15:14 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Helper\HelperInterface` as the method `ask()` does only exist in the following implementations of said interface: `Symfony\Component\Console\Helper\QuestionHelper`, `Symfony\Component\Consol...r\SymfonyQuestionHelper`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
126		$input->setArgument($name, $answer);
127		}
128		}
129		}
130

awurth / Slim

Push — master ( ad54cf...a5bc07 )

CreateUserCommand::interact() C

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like