Issues in UserManager.php (master) - Issues in master - awurth/silex-user - Measure and Improve Code Quality continuously with Scrutinizer

Issues (29)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Model/UserManager.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the awurth/silex-user package.
 *
 * (c) Alexis Wurth <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace AWurth\Silex\User\Model;

use Doctrine\Common\Persistence\ObjectManager;
use Doctrine\Common\Persistence\ObjectRepository;
use Symfony\Component\Security\Core\Encoder\BCryptPasswordEncoder;
use Symfony\Component\Security\Core\Encoder\EncoderFactoryInterface;

class UserManager implements UserManagerInterface
{
    /**
     * @var string
     */
    protected $class;

    /**
     * @var EncoderFactoryInterface
     */
    protected $encoderFactory;

    /**
     * @var ObjectManager
     */
    protected $objectManager;

    /**
     * Constructor.
     *
     * @param ObjectManager           $objectManager
     * @param EncoderFactoryInterface $encoderFactory
     * @param string                  $class
     */
    public function __construct(ObjectManager $objectManager, EncoderFactoryInterface $encoderFactory, $class)
    {
        $this->objectManager = $objectManager;
        $this->encoderFactory = $encoderFactory;
        $this->class = $class;
    }

    /**
     * Gets the Doctrine repository for the User class.
     *
     * @return ObjectRepository
     */
    protected function getRepository()
    {
        return $this->objectManager->getRepository($this->getClass());
    }

    /**
     * {@inheritdoc}
     */
    public function createUser()
    {
        $class = $this->getClass();

        return new $class();
    }

    /**
     * {@inheritdoc}
     */
    public function deleteUser(UserInterface $user)
    {
        $this->objectManager->remove($user);
        $this->objectManager->flush();
    }

    /**
     * {@inheritdoc}
     */
    public function findUserBy(array $criteria)
    {
        return $this->getRepository()->findOneBy($criteria);
    }

    /**
     * {@inheritdoc}
     */
    public function findUserByEmail($email)
    {
        return $this->findUserBy(array('email' => $email));
    }

    /**
     * {@inheritdoc}
     */
    public function findUserByUsername($username)
    {
        return $this->findUserBy(array('username' => $username));
    }

    /**
     * {@inheritdoc}
     */
    public function findUserByUsernameOrEmail($usernameOrEmail)
    {
        if (preg_match('/^.+\@\S+\.\S+$/', $usernameOrEmail)) {
            return $this->findUserByEmail($usernameOrEmail);
        }

        return $this->findUserByUsername($usernameOrEmail);
    }

    /**
     * {@inheritdoc}
     */
    public function findUserByConfirmationToken($token)
    {
        return $this->findUserBy(['confirmationToken' => $token]);
    }

    /**
     * {@inheritdoc}
     */
    public function findUsers()
    {
        return $this->getRepository()->findAll();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * {@inheritdoc}
     */
    public function getClass()
    {
        return $this->class;
    }

    /**
     * {@inheritdoc}
     */
    public function updatePassword(UserInterface $user)
    {
        $plainPassword = $user->getPlainPassword();

        if (0 === strlen($plainPassword)) {
            return;
        }

        $encoder = $this->encoderFactory->getEncoder($user);
        if ($encoder instanceof BCryptPasswordEncoder) {
            $user->setSalt(null);
        } else {
            $user->setSalt(rtrim(str_replace('+', '.', base64_encode(random_bytes(32))), '='));
        }

        $user->setPassword($encoder->encodePassword($plainPassword, $user->getSalt()));
        $user->eraseCredentials();
    }

    /**
     * {@inheritdoc}
     */
    public function updateUser(UserInterface $user, $flush = true)
    {
        $this->updatePassword($user);

        $this->objectManager->persist($user);
        if ($flush) {
            $this->objectManager->flush();
        }
    }
}


1			<?php
2
3			/*
4			* This file is part of the awurth/silex-user package.
5			*
6			* (c) Alexis Wurth <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace AWurth\Silex\User\Model;
13
14			use Doctrine\Common\Persistence\ObjectManager;
15			use Doctrine\Common\Persistence\ObjectRepository;
16			use Symfony\Component\Security\Core\Encoder\BCryptPasswordEncoder;
17			use Symfony\Component\Security\Core\Encoder\EncoderFactoryInterface;
18
19			class UserManager implements UserManagerInterface
20			{
21			/**
22			* @var string
23			*/
24			protected $class;
25
26			/**
27			* @var EncoderFactoryInterface
28			*/
29			protected $encoderFactory;
30
31			/**
32			* @var ObjectManager
33			*/
34			protected $objectManager;
35
36			/**
37			* Constructor.
38			*
39			* @param ObjectManager $objectManager
40			* @param EncoderFactoryInterface $encoderFactory
41			* @param string $class
42			*/
43			public function __construct(ObjectManager $objectManager, EncoderFactoryInterface $encoderFactory, $class)
44			{
45			$this->objectManager = $objectManager;
46			$this->encoderFactory = $encoderFactory;
47			$this->class = $class;
48			}
49
50			/**
51			* Gets the Doctrine repository for the User class.
52			*
53			* @return ObjectRepository
54			*/
55			protected function getRepository()
56			{
57			return $this->objectManager->getRepository($this->getClass());
58			}
59
60			/**
61			* {@inheritdoc}
62			*/
63			public function createUser()
64			{
65			$class = $this->getClass();
66
67			return new $class();
68			}
69
70			/**
71			* {@inheritdoc}
72			*/
73			public function deleteUser(UserInterface $user)
74			{
75			$this->objectManager->remove($user);
76			$this->objectManager->flush();
77			}
78
79			/**
80			* {@inheritdoc}
81			*/
82			public function findUserBy(array $criteria)
83			{
84			return $this->getRepository()->findOneBy($criteria);
85			}
86
87			/**
88			* {@inheritdoc}
89			*/
90			public function findUserByEmail($email)
91			{
92			return $this->findUserBy(array('email' => $email));
93			}
94
95			/**
96			* {@inheritdoc}
97			*/
98			public function findUserByUsername($username)
99			{
100			return $this->findUserBy(array('username' => $username));
101			}
102
103			/**
104			* {@inheritdoc}
105			*/
106			public function findUserByUsernameOrEmail($usernameOrEmail)
107			{
108			if (preg_match('/^.+\@\S+\.\S+$/', $usernameOrEmail)) {
109			return $this->findUserByEmail($usernameOrEmail);
110			}
111
112			return $this->findUserByUsername($usernameOrEmail);
113			}
114
115			/**
116			* {@inheritdoc}
117			*/
118			public function findUserByConfirmationToken($token)
119			{
120			return $this->findUserBy(['confirmationToken' => $token]);
121			}
122
123			/**
124			* {@inheritdoc}
125			*/
126			public function findUsers()
127			{
128			return $this->getRepository()->findAll();
			0 ignored issues – show Bug Best Practice introduced 2017-10-22 11:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this->getRepository()->findAll();` (`array`) is incompatible with the return type declared by the interface `AWurth\Silex\User\Model\...gerInterface::findUsers` of type `Traversable`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
129			}
130
131			/**
132			* {@inheritdoc}
133			*/
134			public function getClass()
135			{
136			return $this->class;
137			}
138
139			/**
140			* {@inheritdoc}
141			*/
142			public function updatePassword(UserInterface $user)
143			{
144			$plainPassword = $user->getPlainPassword();
145
146			if (0 === strlen($plainPassword)) {
147			return;
148			}
149
150			$encoder = $this->encoderFactory->getEncoder($user);
151			if ($encoder instanceof BCryptPasswordEncoder) {
152			$user->setSalt(null);
153			} else {
154			$user->setSalt(rtrim(str_replace('+', '.', base64_encode(random_bytes(32))), '='));
155			}
156
157			$user->setPassword($encoder->encodePassword($plainPassword, $user->getSalt()));
158			$user->eraseCredentials();
159			}
160
161			/**
162			* {@inheritdoc}
163			*/
164			public function updateUser(UserInterface $user, $flush = true)
165			{
166			$this->updatePassword($user);
167
168			$this->objectManager->persist($user);
169			if ($flush) {
170			$this->objectManager->flush();
171			}
172			}
173			}
174

awurth / silex-user

Issues (29)

Security Analysis not enabled

src/Model/UserManager.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like