AuthController::register() - Code Metrics - awurth/Slim - Measure and Improve Code Quality continuously with Scrutinizer

AuthController::register() B
last analyzed 2019-09-01 10:11 UTC

↳ Parent: AuthController

Complexity

Conditions	5
Paths	9

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	55
rs	8.6707
c	0
b	0
f	0
cc	5
nc	9
nop	2

How to fix Long Method

<?php

namespace App\Controller;

use Awurth\Slim\Helper\Controller\Controller;
use Awurth\SlimValidation\Validator;
use Cartalyst\Sentinel\Checkpoints\ThrottlingException;
use Cartalyst\Sentinel\Roles\EloquentRole;
use Cartalyst\Sentinel\Sentinel;
use Respect\Validation\Validator as V;
use Slim\Http\Request;
use Slim\Http\Response;

/**
 * @property Validator validator
 * @property Sentinel  auth
 */
class AuthController extends Controller
{
    public function login(Request $request, Response $response)
    {
        if ($request->isPost()) {
            $credentials = [
                'username' => $request->getParam('username'),
                'password' => $request->getParam('password')
            ];
            $remember = (bool)$request->getParam('remember');

            try {
                if ($this->auth->authenticate($credentials, $remember)) {
                    $this->flash('success', 'You are now logged in.');

                    return $this->redirect($response, 'home');
                } else {
                    $this->validator->addError('auth', 'Bad username or password');
                }
            } catch (ThrottlingException $e) {
                $this->validator->addError('auth', 'Too many attempts!');
            }
        }

        return $this->render($response, 'auth/login.twig');
    }

    public function register(Request $request, Response $response)
    {
        if ($request->isPost()) {
            $username = $request->getParam('username');
            $email = $request->getParam('email');
            $password = $request->getParam('password');

            $this->validator->request($request, [
                'username' => V::length(3, 25)->alnum('_')->noWhitespace(),
                'email' => V::noWhitespace()->email(),
                'password' => [
                    'rules' => V::noWhitespace()->length(6, 25),
                    'messages' => [
                        'length' => 'The password length must be between {{minValue}} and {{maxValue}} characters'
                    ]
                ],
                'password_confirm' => [
                    'rules' => V::equals($password),
                    'messages' => [
                        'equals' => 'Passwords don\'t match'
                    ]
                ]
            ]);

            if ($this->auth->findByCredentials(['login' => $username])) {
                $this->validator->addError('username', 'This username is already used.');
            }

            if ($this->auth->findByCredentials(['login' => $email])) {
                $this->validator->addError('email', 'This email is already used.');
            }

            if ($this->validator->isValid()) {
                /** @var EloquentRole $role */
                $role = $this->auth->findRoleByName('User');

                $user = $this->auth->registerAndActivate([
                    'username' => $username,
                    'email' => $email,
                    'password' => $password,
                    'permissions' => [
                        'user.delete' => 0
                    ]
                ]);

                $role->users()->attach($user);

                $this->flash('success', 'Your account has been created.');

                return $this->redirect($response, 'login');
            }
        }

        return $this->render($response, 'auth/register.twig');
    }

    public function logout(Request $request, Response $response)

    {
        $this->auth->logout();

        return $this->redirect($response, 'home');
    }
}


1			<?php
2
3			namespace App\Controller;
4
5			use Awurth\Slim\Helper\Controller\Controller;
6			use Awurth\SlimValidation\Validator;
7			use Cartalyst\Sentinel\Checkpoints\ThrottlingException;
8			use Cartalyst\Sentinel\Roles\EloquentRole;
9			use Cartalyst\Sentinel\Sentinel;
10			use Respect\Validation\Validator as V;
11			use Slim\Http\Request;
12			use Slim\Http\Response;
13
14			/**
15			* @property Validator validator
16			* @property Sentinel auth
17			*/
18			class AuthController extends Controller
19			{
20			public function login(Request $request, Response $response)
21			{
22			if ($request->isPost()) {
23			$credentials = [
24			'username' => $request->getParam('username'),
25			'password' => $request->getParam('password')
26			];
27			$remember = (bool)$request->getParam('remember');
28
29			try {
30			if ($this->auth->authenticate($credentials, $remember)) {
31			$this->flash('success', 'You are now logged in.');
32
33			return $this->redirect($response, 'home');
34			} else {
35			$this->validator->addError('auth', 'Bad username or password');
36			}
37			} catch (ThrottlingException $e) {
38			$this->validator->addError('auth', 'Too many attempts!');
39			}
40			}
41
42			return $this->render($response, 'auth/login.twig');
43			}
44
45			public function register(Request $request, Response $response)
46			{
47			if ($request->isPost()) {
48			$username = $request->getParam('username');
49			$email = $request->getParam('email');
50			$password = $request->getParam('password');
51
52			$this->validator->request($request, [
53			'username' => V::length(3, 25)->alnum('_')->noWhitespace(),
54			'email' => V::noWhitespace()->email(),
55			'password' => [
56			'rules' => V::noWhitespace()->length(6, 25),
57			'messages' => [
58			'length' => 'The password length must be between {{minValue}} and {{maxValue}} characters'
59			]
60			],
61			'password_confirm' => [
62			'rules' => V::equals($password),
63			'messages' => [
64			'equals' => 'Passwords don\'t match'
65			]
66			]
67			]);
68
69			if ($this->auth->findByCredentials(['login' => $username])) {
70			$this->validator->addError('username', 'This username is already used.');
71			}
72
73			if ($this->auth->findByCredentials(['login' => $email])) {
74			$this->validator->addError('email', 'This email is already used.');
75			}
76
77			if ($this->validator->isValid()) {
78			/** @var EloquentRole $role */
79			$role = $this->auth->findRoleByName('User');
80
81			$user = $this->auth->registerAndActivate([
82			'username' => $username,
83			'email' => $email,
84			'password' => $password,
85			'permissions' => [
86			'user.delete' => 0
87			]
88			]);
89
90			$role->users()->attach($user);
91
92			$this->flash('success', 'Your account has been created.');
93
94			return $this->redirect($response, 'login');
95			}
96			}
97
98			return $this->render($response, 'auth/register.twig');
99			}
100
101			public function logout(Request $request, Response $response)
			0 ignored issues – show Unused Code introduced 2017-10-14 15:14 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
102			{
103			$this->auth->logout();
104
105			return $this->redirect($response, 'home');
106			}
107			}
108

awurth / Slim

AuthController::register() B last analyzed 2019-09-01 10:11 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

AuthController::register() B
last analyzed 2019-09-01 10:11 UTC