awssat / laravel-visits

src/Traits/Record.php

<?php

namespace Awssat\Visits\Traits;

use Spatie\Referer\Referer;

trait Record
{
    /**
     * @param $inc
     */
    protected function recordCountry($inc)
    {
        $this->connection->increment($this->keys->visits."_countries:{$this->keys->id}", $inc, $this->getVisitorCountry());
    }

    /**
     * @param $inc
     */
    protected function recordRefer($inc)
    {
        $this->connection->increment($this->keys->visits."_referers:{$this->keys->id}", $inc, $this->getVisitorReferer());
    }

    /**
     * @param $inc
     */
    protected function recordOperatingSystem($inc)
    {
        $this->connection->increment($this->keys->visits."_OSes:{$this->keys->id}", $inc, $this->getVisitorOperatingSystem());
    }

    /**
     * @param $inc
     */
    protected function recordLanguage($inc)
    {
        $this->connection->increment($this->keys->visits."_languages:{$this->keys->id}", $inc, $this->getVisitorLanguage());
    }

    /**
     * @param $inc
     */
    protected function recordPeriods($inc)
    {
        foreach ($this->periods as $period) {
            $periodKey = $this->keys->period($period);

            $this->connection->increment($periodKey, $inc, $this->keys->id);
            $this->connection->increment($periodKey.'_total', $inc);
        }
    }

    /**
     *  Gets visitor country code
     * @return mixed|string
     */
    public function getVisitorCountry()
    {
        //In case of using unsupported cache driver. Although 'country' is globally  
        //ignored already, we can not rely on user awareness of geoIP package restriction.
        if (
            in_array(config('cache.default'),  ['file', 'dynamodb', 'database']) &&
            is_array($geoipTags = config('geoip.cache_tags')) && count($geoipTags) > 0
        ) {
            return null;
        }

        return strtolower(geoip()->getLocation()->iso_code);

It seems like geoip()->getLocation()->iso_code can also be of type null; however, parameter $string of strtolower() does only seem to accept string, maybe add an additional type check?

    }

    /**
     *  Gets visitor operating system
     * @return mixed|string
     */
    public function getVisitorOperatingSystem()
    {
        $osArray = [
        '/windows|win32|win16|win95/i' => 'Windows',
        '/iphone/i' => 'iPhone',
        '/ipad/i' => 'iPad',
        '/macintosh|mac os x|mac_powerpc/i' => 'MacOS',
        '/(?=.*mobile)android/i' => 'AndroidMobile',
        '/(?!.*mobile)android/i' => 'AndroidTablet',
        '/android/i' => 'Android',
        '/blackberry/i' => 'BlackBerry',
        '/linux/i' => 'Linux',
        ];

        foreach ($osArray as $regex => $value) {
            if (preg_match($regex, request()->server('HTTP_USER_AGENT') ?? '')) {

It seems like request()->server('HTTP_USER_AGENT') ?? '' can also be of type array; however, parameter $subject of preg_match() does only seem to accept string, maybe add an additional type check?

                return $value;
            }
        }

        return 'unknown';
    }

    /**
     *  Gets visitor language
     * @return mixed|string
     */
    public function getVisitorLanguage()
    {
        $language = request()->getPreferredLanguage();
        if (false !== $position = strpos($language, '_')) {

It seems like $language can also be of type null; however, parameter $haystack of strpos() does only seem to accept string, maybe add an additional type check?

            $language = substr($language, 0, $position);

It seems like $language can also be of type null; however, parameter $string of substr() does only seem to accept string, maybe add an additional type check?

        }
        return $language;
    }

    /**
     *  Gets visitor referer
     * @return mixed|string
     */
    public function getVisitorReferer()
    {
        return app(Referer::class)->get();
    }
}