awssat / laravel-kabsa

src/Traits/Kabsa.php

<?php

namespace Awssat\Kabsa\Traits;

use Illuminate\Database\Eloquent\Collection;


trait Kabsa
{
    /**
     * @var Collection
     */
    protected static $kabsaCollection;

    public static function bootKabsa()
    {
        self::unguard();
    }

    public function getRows()
    {
        return $this->rows;
    }

    public static function all($columns = [])

The parameter $columns is not used and could be removed.

    {
        if(!empty(static::$kabsaCollection)) {
            return static::$kabsaCollection;
        }

        return static::$kabsaCollection = Collection::make(
            (new static)->getRows() ?? [])
            ->map(function ($row) {
                return new static($row);

The call to Awssat\Kabsa\Traits\Kabsa::__construct() has too many arguments starting with $row.

            });
    }

    public static function addRow($row)
    {
        if(static::$kabsaCollection instanceof Collection) {

static::kabsaCollection is always a sub-type of Illuminate\Database\Eloquent\Collection.

            static::$kabsaCollection->push(new static($row));

The call to Awssat\Kabsa\Traits\Kabsa::__construct() has too many arguments starting with $row.

        } else {
            static::$kabsaCollection = Collection::make([new static($row)]);
        }

        return true;
    }

    public function __call($method, $parameters)
    {
        return $this->forwardCallTo(self::all(), $method, $parameters);

The method forwardCallTo() does not exist on Awssat\Kabsa\Traits\Kabsa. Since you implemented __call, consider adding a @method annotation.

    }
}