Header::__construct() - Code Metrics - Inspection of "Reorder classes (#4)" - aweapi/openapi-elements - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 935a4f...80b369 )

by Veaceslav

created 2019-10-12 14:05 UTC

Header::__construct() A

↳ Parent: Header

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	30
ccs	4
cts	4
cp	1
rs	9.44
c	0
b	0
f	0
cc	1
nc	1
nop	11
crap	1

How to fix Many Parameters

<?php

declare(strict_types=1);

namespace Aweapi\Openapi\Objects;

use Aweapi\Openapi\Extensions;

final class Header extends Parameter implements HeaderAggregate
{
    public function __construct(
        SchemaAggregate $schema = null,
        MediaTypes $content = null,
        string $description = null,
        bool $required = null,
        bool $deprecated = false,
        bool $allowEmptyValue = false,
        string $style = null,
        bool $explode = null,
        bool $allowReserved = false,
        Examples $examples = null,
        Extensions $extensions = null
    ) {
        parent::__construct(
            // The name MUST not be used.
            '',
            'header',
            $schema,
            $content,
            $description,
            $required,
            $deprecated,
            $allowEmptyValue,
            $style,
            $explode,
            $allowReserved,
            $examples,
            $extensions
        );
    }

    protected function normalizeRequiredProperties(): array
    {
        $fields = parent::normalizeRequiredProperties();
        unset(
            // The field `name` MUST NOT be specified, it is given in the corresponding headers map.
            $fields['name'],
            // The field `in` MUST NOT be specified, it is implicitly in `header`.
            $fields['in']
        );

        return $fields;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Aweapi\Openapi\Objects;
6
7		use Aweapi\Openapi\Extensions;
8
9		final class Header extends Parameter implements HeaderAggregate
10		{
11	6	public function __construct(
12		SchemaAggregate $schema = null,
13		MediaTypes $content = null,
14		string $description = null,
15		bool $required = null,
16		bool $deprecated = false,
17		bool $allowEmptyValue = false,
18		string $style = null,
19		bool $explode = null,
20		bool $allowReserved = false,
21		Examples $examples = null,
22		Extensions $extensions = null
23		) {
24	6	parent::__construct(
25		// The name MUST not be used.
26	6	'',
27	6	'header',
28		$schema,
29		$content,
30		$description,
31		$required,
32		$deprecated,
33		$allowEmptyValue,
34		$style,
35		$explode,
36		$allowReserved,
37		$examples,
38		$extensions
39		);
40		}
41
42	5	protected function normalizeRequiredProperties(): array
43		{
44	5	$fields = parent::normalizeRequiredProperties();
45		unset(
46		// The field `name` MUST NOT be specified, it is given in the corresponding headers map.
47	5	$fields['name'],
48		// The field `in` MUST NOT be specified, it is implicitly in `header`.
49	5	$fields['in']
50		);
51
52	5	return $fields;
53		}
54		}
55

aweapi / openapi-elements

Push — master ( 935a4f...80b369 )

Header::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like