Driver::getFks() - Code Metrics - aviat4ion/Query - Measure and Improve Code Quality continuously with Scrutinizer

Driver::getFks() A
last analyzed 2019-12-10 17:36 UTC

↳ Parent: Driver

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
nc	4
nop	1
dl	0
loc	22
rs	9.568
c	0
b	0
f	0

<?php declare(strict_types=1);
/**
 * Query
 *
 * SQL Query Builder / Database Abstraction Layer
 *
 * PHP version 7.1
 *
 * @package     Query
 * @author      Timothy J. Warren <[email protected]>
 * @copyright   2012 - 2018 Timothy J. Warren
 * @license     http://www.opensource.org/licenses/mit-license.html  MIT License
 * @link        https://git.timshomepage.net/aviat4ion/Query
 */
namespace Query\Drivers\Pgsql;

use Query\Drivers\AbstractDriver;

/**
 * PostgreSQL specific class
 */
class Driver extends AbstractDriver {

	/**
	 * Connect to a PosgreSQL database
	 *
	 * @codeCoverageIgnore
	 * @param string $dsn
	 * @param string $username
	 * @param string $password
	 * @param array  $options
	 */
	public function __construct(string $dsn, string $username=NULL, string $password=NULL, array $options=[])
	{
		if (strpos($dsn, 'pgsql') === FALSE)
		{
			$dsn = 'pgsql:'.$dsn;
		}

		parent::__construct($dsn, $username, $password, $options);
	}

	/**
	 * Get a list of schemas for the current connection
	 *
	 * @return array
	 */
	public function getSchemas(): ?array
	{
		$sql = <<<SQL
			SELECT DISTINCT "schemaname" FROM "pg_tables"
			WHERE "schemaname" NOT LIKE 'pg\_%'
			AND "schemaname" != 'information_schema'
SQL;

		return $this->driverQuery($sql);
	}

	/**
	 * Retrieve foreign keys for the table
	 *
	 * @param string $table
	 * @return array
	 */
	public function getFks($table): array
	{
		$valueMap = [
			'c' => 'CASCADE',
			'r' => 'RESTRICT',
		];

		$keys = parent::getFks($table);

		foreach($keys as &$key)
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
		{
			foreach(['update', 'delete'] AS $type)
			{
				if ( ! isset($valueMap[$key[$type]])) continue;


				$key[$type] = $valueMap[$key[$type]];
			}
		}

		return $keys;
	}
}

1			<?php declare(strict_types=1);
2			/**
3			* Query
4			*
5			* SQL Query Builder / Database Abstraction Layer
6			*
7			* PHP version 7.1
8			*
9			* @package Query
10			* @author Timothy J. Warren <[email protected]>
11			* @copyright 2012 - 2018 Timothy J. Warren
12			* @license http://www.opensource.org/licenses/mit-license.html MIT License
13			* @link https://git.timshomepage.net/aviat4ion/Query
14			*/
15			namespace Query\Drivers\Pgsql;
16
17			use Query\Drivers\AbstractDriver;
18
19			/**
20			* PostgreSQL specific class
21			*/
22			class Driver extends AbstractDriver {
23
24			/**
25			* Connect to a PosgreSQL database
26			*
27			* @codeCoverageIgnore
28			* @param string $dsn
29			* @param string $username
30			* @param string $password
31			* @param array $options
32			*/
33			public function __construct(string $dsn, string $username=NULL, string $password=NULL, array $options=[])
34			{
35			if (strpos($dsn, 'pgsql') === FALSE)
36			{
37			$dsn = 'pgsql:'.$dsn;
38			}
39
40			parent::__construct($dsn, $username, $password, $options);
41			}
42
43			/**
44			* Get a list of schemas for the current connection
45			*
46			* @return array
47			*/
48			public function getSchemas(): ?array
49			{
50			$sql = <<<SQL
51			SELECT DISTINCT "schemaname" FROM "pg_tables"
52			WHERE "schemaname" NOT LIKE 'pg\_%'
53			AND "schemaname" != 'information_schema'
54			SQL;
55
56			return $this->driverQuery($sql);
57			}
58
59			/**
60			* Retrieve foreign keys for the table
61			*
62			* @param string $table
63			* @return array
64			*/
65			public function getFks($table): array
66			{
67			$valueMap = [
68			'c' => 'CASCADE',
69			'r' => 'RESTRICT',
70			];
71
72			$keys = parent::getFks($table);
73
74			foreach($keys as &$key)
			0 ignored issues – show Bug introduced 2018-01-22 20:45 UTC by Report Bug Copy Issue Report The expression `$keys` of type `array\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
75			{
76			foreach(['update', 'delete'] AS $type)
77			{
78			if ( ! isset($valueMap[$key[$type]])) continue;
79
80
81			$key[$type] = $valueMap[$key[$type]];
82			}
83			}
84
85			return $keys;
86			}
87			}

aviat4ion / Query

Driver::getFks() A last analyzed 2019-12-10 17:36 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Driver::getFks() A
last analyzed 2019-12-10 17:36 UTC