Aurawindsurfing\Messenger\Http\Controllers\MessagesController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	24	5
A	create()	0	21	3
A	store()	0	13	1

<?php

namespace Aurawindsurfing\Messenger\Http\Controllers;

use App\User;
use Illuminate\Support\Facades\Auth;
use Aurawindsurfing\Messenger\Thread;

class MessagesController
{
    public function index(Thread $thread)
    {
        $user = Auth::user();

        if (! isset($user)) {
            return abort(404);
        }

        if (! $thread->users()->get()->contains($user)) {
            return abort(404);
        }

        $contacts = User::all();
        $threads = null;
        $activeThread = Thread::find($thread->id);

The property id does not exist on object<Aurawindsurfing\Messenger\Thread>. Since you implemented __get, maybe consider adding a @property annotation.

        if (isset($user)) {
            if ($user->threads()->exists()) {

The method threads() does not seem to exist on object<Illuminate\Contracts\Auth\Authenticatable>.

                $threads = $user->threads()->with('messages')->get();

The method threads() does not seem to exist on object<Illuminate\Contracts\Auth\Authenticatable>.

            }
        }

        return view('vendor.messenger.index', compact('threads', 'activeThread', 'contacts'));
    }

    public function create($user)
    {
        $fromUser = Auth::user();
        $contacts = User::all();
        $threads = collect([]);

        $activeThread = Thread::firstOrCreate([
            'from_user_id' => $fromUser->id,

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            'to_user_id'   => $user,
        ]);

        if (isset($fromUser)) {
            if ($fromUser->threads()->exists()) {

The method threads() does not seem to exist on object<Illuminate\Contracts\Auth\Authenticatable>.

                $threads = $fromUser->threads()->with('messages')->get();

The method threads() does not seem to exist on object<Illuminate\Contracts\Auth\Authenticatable>.

            }
        }

        $threads = collect([$activeThread])->merge($threads);

        return view('vendor.messenger.index', compact('threads', 'activeThread', 'contacts'));
    }

    public function store(Thread $thread)
    {
        request()->merge(['user_id' => Auth::user()->id]);

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        request()->validate([
            'body'    => 'required',
            'user_id' => 'required',
        ]);

        $thread->addMessage(request('body'), Auth::user()->id);

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        return redirect($thread->path());
    }
}