ReturningTrait - Code Metrics - Inspection of "move pgsql-specific RETURNING out of common" - auraphp/Aura.SqlQuery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.x-builder ( 46541a...6c1cc6 )

by Paul

created 2017-03-17 18:32 UTC

ReturningTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	2
lcom	1
cbo	0
dl	0
loc	31
ccs	5
cts	5
cp	1
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	returning()	0	7	2

<?php
/**
 *
 * This file is part of Aura for PHP.
 *
 * @license http://opensource.org/licenses/bsd-license.php BSD
 *
 */
namespace Aura\SqlQuery\Pgsql;

/**
 *
 * Common code for RETURNING clauses.
 *
 * @package Aura.SqlQuery
 *
 */
trait ReturningTrait
{
    /**
     *
     * The columns to be returned.
     *
     * @var array
     *
     */
    protected $returning = [];

    /**
     *
     * Adds returning columns to the query.
     *
     * Multiple calls to returning() will append to the list of columns, not
     * overwrite the previous columns.
     *
     * @param array $cols The column(s) to add to the query.
     *
     * @return $this
     *
     */
    public function returning(array $cols)
    {
        foreach ($cols as $col) {
            $this->returning[] = $this->quoter->quoteNamesIn($col);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
        return $this;
    }
}


1		<?php
2		/**
3		*
4		* This file is part of Aura for PHP.
5		*
6		* @license http://opensource.org/licenses/bsd-license.php BSD
7		*
8		*/
9		namespace Aura\SqlQuery\Pgsql;
10
11		/**
12		*
13		* Common code for RETURNING clauses.
14		*
15		* @package Aura.SqlQuery
16		*
17		*/
18		trait ReturningTrait
19		{
20		/**
21		*
22		* The columns to be returned.
23		*
24		* @var array
25		*
26		*/
27		protected $returning = [];
28
29		/**
30		*
31		* Adds returning columns to the query.
32		*
33		* Multiple calls to returning() will append to the list of columns, not
34		* overwrite the previous columns.
35		*
36		* @param array $cols The column(s) to add to the query.
37		*
38		* @return $this
39		*
40		*/
41	3	public function returning(array $cols)
42		{
43	3	foreach ($cols as $col) {
44	3	$this->returning[] = $this->quoter->quoteNamesIn($col);
		0 ignored issues – show Bug introduced 2017-03-17 18:34 UTC by Report Bug Copy Issue Report The property `quoter` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
45	3	}
46	3	return $this;
47		}
48		}
49

auraphp / Aura.SqlQuery

Push — 3.x-builder ( 46541a...6c1cc6 )

ReturningTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

Duplication Side-by-Side

Filter issues like