BuildReturningTrait::buildReturning() - Code Metrics - Inspection of "remove quoter from insert/update and put in builde..." - auraphp/Aura.SqlQuery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.x-builder-quoter ( 067851 )

by Paul

created 2017-03-17 21:00 UTC

BuildReturningTrait::buildReturning() A

↳ Parent: BuildReturningTrait

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	8
cts	8
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	7
nc	3
nop	1
crap	3

<?php
namespace Aura\SqlQuery\Pgsql;

trait BuildReturningTrait
{
    /**
     *
     * Builds the `RETURNING` clause of the statement.
     *
     * @return string
     *
     */
    public function buildReturning($returning)
    {
        if (empty($returning)) {
            return ''; // not applicable
        }

        $cols = [];
        foreach ($returning as $col) {
            $cols[] = $this->quoter->quoteNamesIn($col);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
        return PHP_EOL . 'RETURNING' . $this->indentCsv($cols);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2		namespace Aura\SqlQuery\Pgsql;
3
4		trait BuildReturningTrait
5		{
6		/**
7		*
8		* Builds the `RETURNING` clause of the statement.
9		*
10		* @return string
11		*
12		*/
13	11	public function buildReturning($returning)
14		{
15	11	if (empty($returning)) {
16	8	return ''; // not applicable
17		}
18
19	3	$cols = [];
20	3	foreach ($returning as $col) {
21	3	$cols[] = $this->quoter->quoteNamesIn($col);
		0 ignored issues – show Bug introduced 2017-03-17 21:02 UTC by Report Bug Copy Issue Report The property `quoter` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
22	3	}
23	3	return PHP_EOL . 'RETURNING' . $this->indentCsv($cols);
		0 ignored issues – show Bug introduced 2017-03-17 21:02 UTC by Report Bug Copy Issue Report It seems like `indentCsv()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24		}
25		}
26

auraphp / Aura.SqlQuery

Push — 3.x-builder-quoter ( 067851 )

BuildReturningTrait::buildReturning() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like