UpdateBuilder::buildValuesForUpdate() - Code Metrics - Inspection of "remove quoter from insert/update and put in builde..." - auraphp/Aura.SqlQuery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.x-builder-quoter ( 067851 )

by Paul

created 2017-03-17 21:00 UTC

UpdateBuilder::buildValuesForUpdate() A

↳ Parent: UpdateBuilder

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3.072

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	8
cts	10
cp	0.8
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	8
nc	3
nop	1
crap	3.072

<?php
namespace Aura\SqlQuery\Common;

use Aura\SqlQuery\AbstractBuilder;

class UpdateBuilder extends AbstractBuilder
{
    /**
     *
     * Builds the table clause.
     *
     * @return null
     *
     */
    public function buildTable($table)
    {
        $table = $this->quoter->quoteName($table);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        return " {$table}";
    }

    /**
     *
     * Builds the updated columns and values of the statement.
     *
     * @return string
     *
     */
    public function buildValuesForUpdate($col_values)
    {
        $values = array();
        foreach ($col_values as $col => $value) {
            $col = $this->quoter->quoteName($col);
            if ($value instanceof RawValue) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
                $value = $this->quoter->quoteNamesIn((string) $value);
            }
            $values[] = "{$col} = {$value}";
        }

        return PHP_EOL . 'SET' . $this->indentCsv($values);
    }
}


1		<?php
2		namespace Aura\SqlQuery\Common;
3
4		use Aura\SqlQuery\AbstractBuilder;
5
6		class UpdateBuilder extends AbstractBuilder
7		{
8		/**
9		*
10		* Builds the table clause.
11		*
12		* @return null
13		*
14		*/
15	16	public function buildTable($table)
16		{
17	16	$table = $this->quoter->quoteName($table);
		0 ignored issues – show Bug introduced 2017-03-17 21:02 UTC by Report Bug Copy Issue Report The property `quoter` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
18	16	return " {$table}";
19		}
20
21		/**
22		*
23		* Builds the updated columns and values of the statement.
24		*
25		* @return string
26		*
27		*/
28	16	public function buildValuesForUpdate($col_values)
29		{
30	16	$values = array();
31	16	foreach ($col_values as $col => $value) {
32	16	$col = $this->quoter->quoteName($col);
33	16	if ($value instanceof RawValue) {
		0 ignored issues – show Bug introduced 2017-03-17 21:02 UTC by Report Bug Copy Issue Report The class `Aura\SqlQuery\Common\RawValue` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
34		$value = $this->quoter->quoteNamesIn((string) $value);
35		}
36	16	$values[] = "{$col} = {$value}";
37	16	}
38
39	16	return PHP_EOL . 'SET' . $this->indentCsv($values);
40		}
41		}
42

auraphp / Aura.SqlQuery

Push — 3.x-builder-quoter ( 067851 )

UpdateBuilder::buildValuesForUpdate() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like