InsertBuilder::buildValuesForInsert() - Code Metrics - Inspection of "remove quoter from insert/update and put in builde..." - auraphp/Aura.SqlQuery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.x-builder-quoter ( 067851 )

by Paul

created 2017-03-17 21:00 UTC

InsertBuilder::buildValuesForInsert() A

↳ Parent: InsertBuilder

Complexity

Conditions	3
Paths	3

Size

Total Lines	19
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	3.0261

Importance

Changes

Metric	Value
dl	0
loc	19
ccs	12
cts	14
cp	0.8571
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	14
nc	3
nop	1
crap	3.0261

<?php
namespace Aura\SqlQuery\Common;

use Aura\SqlQuery\AbstractBuilder;

class InsertBuilder extends AbstractBuilder
{

    /**
     *
     * Builds the INTO clause.
     *
     * @return string
     *
     */
    public function buildInto($into)
    {
        $into = $this->quoter->quoteName($into);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        return " INTO {$into}";
    }

    /**
     *
     * Builds the inserted columns and values of the statement.
     *
     * @return string
     *
     */
    public function buildValuesForInsert($col_values)
    {
        $cols = [];
        $values = [];
        foreach ($col_values as $col => $value) {
            $cols[] = $this->quoter->quoteName($col);
            if ($value instanceof RawValue) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
                $values[] = $this->quoter->quoteNamesIn((string) $value);
            } else {
                $values[] = (string) $value;
            }
        }

        return ' ('
            . $this->indentCsv($cols)
            . PHP_EOL . ') VALUES ('
            . $this->indentCsv($values)
            . PHP_EOL . ')';
    }

    /**
     *
     * Builds the bulk-inserted columns and values of the statement.
     *
     * @return string
     *
     */
    public function buildValuesForBulkInsert($col_order, $col_values_bulk)
    {
        $cols = [];
        foreach ($col_order as $col) {
            $cols[] = $this->quoter->quoteName($col);
        }
        $cols = "    (" . implode(', ', $cols) . ")";

        $vals = array();
        foreach ($col_values_bulk as $row_values) {
            $vals[] = "    (" . implode(', ', $row_values) . ")";
        }

        return PHP_EOL . $cols . PHP_EOL
            . "VALUES" . PHP_EOL
            . implode("," . PHP_EOL, $vals);
    }
}


Push — 3.x-builder-quoter ( 067851 )

InsertBuilder::buildValuesForInsert() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

1		<?php
2		namespace Aura\SqlQuery\Common;
3
4		use Aura\SqlQuery\AbstractBuilder;
5
6		class InsertBuilder extends AbstractBuilder
7		{
8
9		/**
10		*
11		* Builds the INTO clause.
12		*
13		* @return string
14		*
15		*/
16	42	public function buildInto($into)
17		{
18	42	$into = $this->quoter->quoteName($into);
		0 ignored issues – show Bug introduced 2017-03-17 21:02 UTC by Report Bug Copy Issue Report The property `quoter` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19	42	return " INTO {$into}";
20		}
21
22		/**
23		*
24		* Builds the inserted columns and values of the statement.
25		*
26		* @return string
27		*
28		*/
29	22	public function buildValuesForInsert($col_values)
30		{
31	22	$cols = [];
32	22	$values = [];
33	22	foreach ($col_values as $col => $value) {
34	22	$cols[] = $this->quoter->quoteName($col);
35	22	if ($value instanceof RawValue) {
		0 ignored issues – show Bug introduced 2017-03-17 21:02 UTC by Report Bug Copy Issue Report The class `Aura\SqlQuery\Common\RawValue` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
36		$values[] = $this->quoter->quoteNamesIn((string) $value);
37		} else {
38	22	$values[] = (string) $value;
39		}
40	22	}
41
42		return ' ('
43	22	. $this->indentCsv($cols)
44	22	. PHP_EOL . ') VALUES ('
45	22	. $this->indentCsv($values)
46	22	. PHP_EOL . ')';
47		}
48
49		/**
50		*
51		* Builds the bulk-inserted columns and values of the statement.
52		*
53		* @return string
54		*
55		*/
56	20	public function buildValuesForBulkInsert($col_order, $col_values_bulk)
57		{
58	20	$cols = [];
59	20	foreach ($col_order as $col) {
60	20	$cols[] = $this->quoter->quoteName($col);
61	20	}
62	20	$cols = " (" . implode(', ', $cols) . ")";
63
64	20	$vals = array();
65	20	foreach ($col_values_bulk as $row_values) {
66	20	$vals[] = " (" . implode(', ', $row_values) . ")";
67	20	}
68
69	20	return PHP_EOL . $cols . PHP_EOL
70	20	. "VALUES" . PHP_EOL
71	20	. implode("," . PHP_EOL, $vals);
72		}
73		}
74

auraphp / Aura.SqlQuery

Push — 3.x-builder-quoter ( 067851 )

InsertBuilder::buildValuesForInsert() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like