Randval::generate() - Code Metrics - Inspection of "Merge pull request #51 from auraphp/2.x" - auraphp/Aura.Session - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.x ( 102317...c3c030 )

by Hari

created 2016-04-11 04:43 UTC

Randval::generate() B

↳ Parent: Randval

Complexity

Conditions	4
Paths	4

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes	4
Bugs	0	Features	1

Metric	Value
c	4
b	0
f	1
dl	0
loc	22
ccs	8
cts	8
cp	1
rs	8.9197
cc	4
eloc	12
nc	4
nop	0
crap	4

<?php
/**
 *
 * This file is part of Aura for PHP.
 *
 * @license http://opensource.org/licenses/bsd-license.php BSD
 *
 */
namespace Aura\Session;

use Aura\Session\Exception;

/**
 *
 * Generates cryptographically-secure random values.
 *
 * @package Aura.Session
 *
 */
class Randval implements RandvalInterface
{
    /**
     *
     * An object to intercept PHP function calls; this makes testing easier.
     *
     * @var Phpfunc
     *
     */
    protected $phpfunc;

    /**
     *
     * Constructor.
     *
     * @param Phpfunc $phpfunc An object to intercept PHP function calls;
     * this makes testing easier.
     *
     */
    public function __construct(Phpfunc $phpfunc)
    {
        $this->phpfunc = $phpfunc;
    }

    /**
     *
     * Returns a cryptographically secure random value.
     *
     * @return string
     *
     * @throws Exception if neither openssl nor mcrypt is available.
     *
     */
    public function generate()
    {
        $bytes = 32;

        if ($this->phpfunc->extension_loaded('openssl')) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return $this->phpfunc->openssl_random_pseudo_bytes($bytes);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }

        if ($this->phpfunc->extension_loaded('mcrypt')) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return $this->phpfunc->mcrypt_create_iv($bytes, MCRYPT_DEV_URANDOM);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }

        if ($this->phpfunc->function_exists('random_bytes')) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return $this->phpfunc->random_bytes($bytes);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }

        $message = "Cannot generate cryptographically secure random values. "
                 . "Please install extension 'openssl' or 'mcrypt', or use "
                 . "another cryptographically secure implementation.";

        throw new Exception($message);
    }
}


1		<?php
2		/**
3		*
4		* This file is part of Aura for PHP.
5		*
6		* @license http://opensource.org/licenses/bsd-license.php BSD
7		*
8		*/
9		namespace Aura\Session;
10
11		use Aura\Session\Exception;
12
13		/**
14		*
15		* Generates cryptographically-secure random values.
16		*
17		* @package Aura.Session
18		*
19		*/
20		class Randval implements RandvalInterface
21		{
22		/**
23		*
24		* An object to intercept PHP function calls; this makes testing easier.
25		*
26		* @var Phpfunc
27		*
28		*/
29		protected $phpfunc;
30
31		/**
32		*
33		* Constructor.
34		*
35		* @param Phpfunc $phpfunc An object to intercept PHP function calls;
36		* this makes testing easier.
37		*
38		*/
39	38	public function __construct(Phpfunc $phpfunc)
40		{
41	38	$this->phpfunc = $phpfunc;
42	38	}
43
44		/**
45		*
46		* Returns a cryptographically secure random value.
47		*
48		* @return string
49		*
50		* @throws Exception if neither openssl nor mcrypt is available.
51		*
52		*/
53	4	public function generate()
54		{
55	4	$bytes = 32;
56
57	4	if ($this->phpfunc->extension_loaded('openssl')) {
		0 ignored issues – show Documentation Bug introduced 2016-03-17 23:12 UTC by Report Bug Copy Issue Report The method `extension_loaded` does not exist on `object<Aura\Session\Phpfunc>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
58	4	return $this->phpfunc->openssl_random_pseudo_bytes($bytes);
		0 ignored issues – show Documentation Bug introduced 2016-03-17 23:12 UTC by Report Bug Copy Issue Report The method `openssl_random_pseudo_bytes` does not exist on `object<Aura\Session\Phpfunc>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
59		}
60
61	1	if ($this->phpfunc->extension_loaded('mcrypt')) {
		0 ignored issues – show Documentation Bug introduced 2016-03-17 23:12 UTC by Report Bug Copy Issue Report The method `extension_loaded` does not exist on `object<Aura\Session\Phpfunc>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
62	1	return $this->phpfunc->mcrypt_create_iv($bytes, MCRYPT_DEV_URANDOM);
		0 ignored issues – show Documentation Bug introduced 2016-03-17 23:12 UTC by Report Bug Copy Issue Report The method `mcrypt_create_iv` does not exist on `object<Aura\Session\Phpfunc>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
63		}
64
65		if ($this->phpfunc->function_exists('random_bytes')) {
		0 ignored issues – show Documentation Bug introduced 2016-03-17 23:12 UTC by Report Bug Copy Issue Report The method `function_exists` does not exist on `object<Aura\Session\Phpfunc>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
66		return $this->phpfunc->random_bytes($bytes);
		0 ignored issues – show Documentation Bug introduced 2016-03-17 23:12 UTC by Report Bug Copy Issue Report The method `random_bytes` does not exist on `object<Aura\Session\Phpfunc>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
67	1	}
68
69	1	$message = "Cannot generate cryptographically secure random values. "
70		. "Please install extension 'openssl' or 'mcrypt', or use "
71		. "another cryptographically secure implementation.";
72
73		throw new Exception($message);
74		}
75		}
76

auraphp / Aura.Session

Push — 3.x ( 102317...c3c030 )

Randval::generate() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like