Aura\Router\Rule\Allows

Complexity

Total Complexity

3

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	9	3

<?php
/**
 *
 * This file is part of Aura for PHP.
 *
 * @license http://opensource.org/licenses/bsd-license.php BSD
 *
 */
namespace Aura\Router\Rule;

use Aura\Router\Route;
use Psr\Http\Message\ServerRequestInterface;

/**
 *
 * A rule for HTTP methods.
 *
 * @package Aura.Router
 *
 */
class Allows implements RuleInterface
{
    /**
     *
     * Does the server request method match an allowed route method?
     *
     * @param ServerRequestInterface $request The HTTP request.
     *
     * @param Route $route The route.
     *
     * @return bool True on success, false on failure.
     *
     */
    public function __invoke(ServerRequestInterface $request, Route $route)
    {
        if (! $route->allows) {

The expression $route->allows of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return true;
        }

        $requestMethod = $request->getMethod() ?: 'GET';
        return in_array($requestMethod, $route->allows);
    }
}