audreyr /
cookiecutter
| Conditions | 11 |
| Total Lines | 63 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like clone() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | # -*- coding: utf-8 -*- |
||
| 60 | def clone(repo_url, checkout=None, clone_to_dir='.', no_input=False): |
||
| 61 | """Clone a repo to the current directory. |
||
| 62 | |||
| 63 | :param repo_url: Repo URL of unknown type. |
||
| 64 | :param checkout: The branch, tag or commit ID to checkout after clone. |
||
| 65 | :param clone_to_dir: The directory to clone to. |
||
| 66 | Defaults to the current directory. |
||
| 67 | :param no_input: Suppress all user prompts when calling via API. |
||
| 68 | """ |
||
| 69 | # Ensure that clone_to_dir exists |
||
| 70 | clone_to_dir = os.path.expanduser(clone_to_dir) |
||
| 71 | make_sure_path_exists(clone_to_dir) |
||
| 72 | |||
| 73 | # identify the repo_type |
||
| 74 | repo_type, repo_url = identify_repo(repo_url) |
||
| 75 | |||
| 76 | # check that the appropriate VCS for the repo_type is installed |
||
| 77 | if not is_vcs_installed(repo_type): |
||
| 78 | msg = "'{0}' is not installed.".format(repo_type) |
||
| 79 | raise VCSNotInstalled(msg) |
||
| 80 | |||
| 81 | repo_url = repo_url.rstrip('/') |
||
| 82 | tail = os.path.split(repo_url)[1] |
||
| 83 | if repo_type == 'git': |
||
| 84 | repo_dir = os.path.normpath(os.path.join(clone_to_dir, |
||
| 85 | tail.rsplit('.git')[0])) |
||
| 86 | elif repo_type == 'hg': |
||
| 87 | repo_dir = os.path.normpath(os.path.join(clone_to_dir, tail)) |
||
| 88 | logger.debug('repo_dir is {0}'.format(repo_dir)) |
||
| 89 | |||
| 90 | if os.path.isdir(repo_dir): |
||
| 91 | clone = prompt_and_delete(repo_dir, no_input=no_input) |
||
| 92 | else: |
||
| 93 | clone = True |
||
| 94 | |||
| 95 | if clone: |
||
| 96 | try: |
||
| 97 | subprocess.check_output( |
||
| 98 | [repo_type, 'clone', repo_url], |
||
| 99 | cwd=clone_to_dir, |
||
| 100 | stderr=subprocess.STDOUT, |
||
| 101 | ) |
||
| 102 | if checkout is not None: |
||
| 103 | subprocess.check_output( |
||
| 104 | [repo_type, 'checkout', checkout], |
||
| 105 | cwd=repo_dir, |
||
| 106 | stderr=subprocess.STDOUT, |
||
| 107 | ) |
||
| 108 | except subprocess.CalledProcessError as clone_error: |
||
| 109 | output = clone_error.output.decode('utf-8') |
||
| 110 | if 'not found' in output.lower(): |
||
| 111 | raise RepositoryNotFound( |
||
| 112 | 'The repository {} could not be found, ' |
||
| 113 | 'have you made a typo?'.format(repo_url) |
||
| 114 | ) |
||
| 115 | if any(error in output for error in BRANCH_ERRORS): |
||
| 116 | raise RepositoryCloneFailed( |
||
| 117 | 'The {} branch of repository {} could not found, ' |
||
| 118 | 'have you made a typo?'.format(checkout, repo_url) |
||
| 119 | ) |
||
| 120 | raise |
||
| 121 | |||
| 122 | return repo_dir |
||
| 123 |
