AL\Common\Model\News\News

Complexity

Total Complexity

10

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	getHtmlText()	0	2	1
A	getDate()	0	2	1
A	getImage()	0	2	1
A	getImageId()	0	2	1
A	getText()	0	2	1
A	getHeadline()	0	2	1
A	getId()	0	2	1
A	getUser()	0	2	1
A	__construct()	0	18	2

<?php
namespace AL\Common\Model\News;

require_once __DIR__."/../../../config/config.php";
require_once __DIR__."/../../../lib/functions.php";

/**
 * Maps to the `news` and `news_image` tables
 */
class News {
    private $id;
    private $headline;
    private $text;
    private $date;
    private $image;
    private $image_id;
    private $userid;

The private property $userid is not used, and could be removed.

    public function __construct(
        $id,
        $headline,
        $text,
        $date,
        $image,
        $image_id,
        $user
    ) {
        $this->id = $id;
        $this->headline = $headline;
        $this->text = $text;
        $this->date = $date;
        $this->user = $user;

The property user does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->image_id = $image_id;

        if ($image != null) {
            $this->image = $GLOBALS['news_images_path'].$image;
        }
    }

    public function getId() {
        return $this->id;
    }

    public function getHeadline() {
        return $this->headline;
    }

    public function getText() {
        return $this->text;
    }

    public function getDate() {
        return $this->date;
    }

    public function getImage() {
        return $this->image;
    }

    public function getImageId() {
        return $this->image_id;
    }

    public function getUser() {
        return $this->user;
    }

    /**
     * @return The HTML-ized version of the text (with the AL code

The type AL\Common\Model\News\The was not found. Maybe you did not declare it correctly or list all dependencies?

     *  rendered to HTML and smilies removed)
     */
    public function getHtmlText() {
        return nl2br(InsertALCode(RemoveSmillies($this->text)));

The expression return nl2br(InsertALCode(RemoveSmillies($this->text))) returns the type string which is incompatible with the documented return type AL\Common\Model\News\The.

    }
}