AL\Common\DAO\NewsSubmissionDAO

Complexity

Total Complexity

13

Size/Duplication

Total Lines	311
Duplicated Lines	0 %

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getAllSubmissions()	0	56	2
A	__construct()	0	2	1
A	getSubmissionCount()	0	29	2
A	getNewsText()	0	21	2
A	getSubmissionQuery()	0	29	2
B	getSpecificSubmissions()	0	79	2
A	getAllSubmissionsForUser()	0	56	2

<?php
namespace AL\Common\DAO;

require_once __DIR__."/../../lib/Db.php" ;
require_once __DIR__."/../../lib/functions.php" ;
require_once __DIR__."/../Model/News/NewsSubmission.php" ;

use AL\Common\Model\NewsSubmission;

/**
 * DAO for News Submlissions
 */
 
class NewsSubmissionDAO {
    private $mysqli;

    public function __construct($mysqli) {
        $this->mysqli = $mysqli;
    }
    
    private function getSubmissionQuery($user_id = null, $news_id = null) {

The parameter $news_id is not used and could be removed.

        $query =  "SELECT
                news_submission.news_submission_id,
                  news_submission.news_headline,
                  news_submission.news_text, 
                  news_submission.news_date,
                  news_image.news_image_id,
                  CONCAT(news_image.news_image_id, \".\", news_image.news_image_ext) as news_image,
                  news_submission.user_id,
                  users.userid,
                  users.email,
                  users.join_date,
                  users.karma,
                  users.show_email,
                  users.avatar_ext,
                  (SELECT COUNT(*) 
                        FROM news_submission 
                            WHERE news_submission.user_id = users.user_id) AS user_submission_count
                  FROM news_submission
                  LEFT JOIN news_image ON (news_submission.news_image_id = news_image.news_image_id)
                  LEFT JOIN users ON (news_submission.user_id = users.user_id)";
              
        if (isset($user_id)) {
            $query .= " WHERE news_submission.user_id = ?";
        }

        $query .= " ORDER BY news_date DESC";

        return $query;
    }
    
    /**
    * Return all news submissions, sorted by descending date
    * @return \AL\Common\Model\News\News[] An array of news
    */
    public function getAllSubmissions() {
        $stmt = \AL\Db\execute_query(
            "NewsSubmissionDAO: getAllSubmissions",
            $this->mysqli,
            $this->getSubmissionQuery(),
            null, null
        );

        \AL\Db\bind_result(
            "NewsSubmissionDAO: get All Submissions",
            $stmt,
            $id,
            $headline,

The variable $headline seems to be never defined.

            $text,

The variable $text seems to be never defined.

            $date,

The variable $date seems to be never defined.

            $image_id,

The variable $image_id seems to be never defined.

            $image,

The variable $image seems to be never defined.

            $userid,

The variable $userid seems to be never defined.

            $username,

The variable $username seems to be never defined.

            $email,

The variable $email seems to be never defined.

            $join_date,

The variable $join_date seems to be never defined.

            $karma,

The variable $karma seems to be never defined.

            $show_email,

The variable $show_email seems to be never defined.

            $avatar_ext,

The variable $avatar_ext seems to be never defined.

            $user_subm_count

The variable $user_subm_count seems to be never defined.

        );

        $news = [];
        
        while ($stmt->fetch()) {
            $text = nl2br($text);

The variable $text does not seem to be defined for all execution paths leading up to this point.

            $text = InsertALCode($text);
            $text = trim($text);
            $text = RemoveSmillies($text);
        
            $news[] = new \AL\Common\Model\NewsSubmission\NewsSubmission(
                $id,
                $headline,
                $text,
                $date,
                $image_id,
                $image,
                $userid,
                $username,
                $email,
                $join_date,
                $karma,
                $show_email,
                $avatar_ext,
                $user_subm_count
            );
        }

        $stmt->close();

        return $news;
    }
    
    /**
    * Return all news submissions, sorted by descending date
    * @return \AL\Common\Model\News\News[] An array of news
    */
    public function getAllSubmissionsForUser($user_id) {
        $stmt = \AL\Db\execute_query(
            "NewsSubmissionDAO: getAllSubmissions",
            $this->mysqli,
            $this->getSubmissionQuery($user_id),
            "i", $user_id
        );

        \AL\Db\bind_result(
            "NewsSubmissionDAO: get All Submissions",
            $stmt,
            $id,
            $headline,

The variable $headline seems to be never defined.

            $text,

The variable $text seems to be never defined.

            $date,

The variable $date seems to be never defined.

            $image_id,

The variable $image_id seems to be never defined.

            $image,

The variable $image seems to be never defined.

            $userid,

The variable $userid does not exist. Did you maybe mean $user_id?

            $username,

The variable $username seems to be never defined.

            $email,

The variable $email seems to be never defined.

            $join_date,

The variable $join_date seems to be never defined.

            $karma,

The variable $karma seems to be never defined.

            $show_email,

The variable $show_email seems to be never defined.

            $avatar_ext,

The variable $avatar_ext seems to be never defined.

            $user_subm_count

The variable $user_subm_count seems to be never defined.

        );

        $news = [];
        
        while ($stmt->fetch()) {
            $text = nl2br($text);

The variable $text does not seem to be defined for all execution paths leading up to this point.

            $text = InsertALCode($text);
            $text = trim($text);
            $text = RemoveSmillies($text);
        
            $news[] = new \AL\Common\Model\NewsSubmission\NewsSubmission(
                $id,
                $headline,
                $text,
                $date,
                $image_id,
                $image,
                $userid,
                $username,
                $email,
                $join_date,
                $karma,
                $show_email,
                $avatar_ext,
                $user_subm_count
            );
        }

        $stmt->close();

        return $news;
    }
    
    
    /**
    * Return a specific news submissions
    * @return \AL\Common\Model\News\News[] An array of news
    */
    public function getSpecificSubmissions($news_id) {
        $stmt = \AL\Db\execute_query(
            "NewsSubmissionDAO: getSpecificSubmissions",
            $this->mysqli,
            "SELECT
            news_submission.news_submission_id,
            news_submission.news_headline,
            news_submission.news_text, 
            news_submission.news_date,
            news_image.news_image_id,
            CONCAT(news_image.news_image_id, \".\", news_image.news_image_ext) as news_image,
            news_submission.user_id,
            users.userid,
            users.email,
            users.join_date,
            users.karma,
            users.show_email,
            users.avatar_ext,
            (SELECT COUNT(*) 
                FROM news_submission 
                    WHERE news_submission.user_id = users.user_id) AS user_submission_count
            FROM news_submission
            LEFT JOIN news_image ON (news_submission.news_image_id = news_image.news_image_id)
            LEFT JOIN users ON (news_submission.user_id = users.user_id)
            WHERE news_submission.news_submission_id = ?",
            "i",
            $news_id
        );

        \AL\Db\bind_result(
            "NewsSubmissionDAO: get specific Submissions",
            $stmt,
            $id,
            $headline,

The variable $headline seems to be never defined.

            $text,

The variable $text seems to be never defined.

            $date,

The variable $date seems to be never defined.

            $image_id,

The variable $image_id seems to be never defined.

            $image,

The variable $image seems to be never defined.

            $userid,

The variable $userid seems to be never defined.

            $username,

The variable $username seems to be never defined.

            $email,

The variable $email seems to be never defined.

            $join_date,

The variable $join_date seems to be never defined.

            $karma,

The variable $karma seems to be never defined.

            $show_email,

The variable $show_email seems to be never defined.

            $avatar_ext,

The variable $avatar_ext seems to be never defined.

            $user_subm_count

The variable $user_subm_count seems to be never defined.

        );

        $news = [];
        
        while ($stmt->fetch()) {
            //$text = nl2br($text);
            //$text = InsertALCode($text);
            //$text = trim($text);
            //$text = RemoveSmillies($text);
            $breaks = array("<br />","<br>","<br/>");
            $text = str_ireplace($breaks, "\r\n", $text);

The variable $text does not seem to be defined for all execution paths leading up to this point.

        
            $news[] = new \AL\Common\Model\NewsSubmission\NewsSubmission(
                $id,
                $headline,
                $text,
                $date,
                $image_id,
                $image,
                $userid,
                $username,
                $email,
                $join_date,
                $karma,
                $show_email,
                $avatar_ext,
                $user_subm_count
            );
        }

        $stmt->close();

        return $news;
    }
  
    /**
    * Get the total count of comments on the website
    *
    * @param  integer $user_id Optional ID of a user to count comments for
    * @return integer Number of comments     */
    public function getSubmissionCount($user_id = null) {
        if (isset($user_id)) {
            $stmt = \AL\Db\execute_query(
                "NewsSubmissionDAO: Get submission count for user_id $user_id",
                $this->mysqli,
                "SELECT COUNT(*) FROM news_submission WHERE user_id = ?",
                "i",
                $user_id
            );
        } else {
            $stmt = \AL\Db\execute_query(
                "NewsSubmissionDAO: Get submission count in database",
                $this->mysqli,
                "SELECT COUNT(*) FROM news_submission",
                null,
                null
            );
        }

        \AL\Db\bind_result(
            "NewsSubmissionDAO: Get submissino count",
            $stmt,
            $count
        );

        $stmt->fetch();
        $stmt->close();

        return $count;
    }
    
    /**
    * Get the comment text for a specific comment
    *
    * @param  integer $comments_id ID of a comment
    * @return text the text of the comment

The type AL\Common\DAO\text was not found. Maybe you did not declare it correctly or list all dependencies?

    */
    public function getNewsText($news_id = null) {
        if (isset($news_id)) {
            $stmt = \AL\Db\execute_query(
                "NewsSubmissionDAO: Get news text for news_id $news_id",
                $this->mysqli,
                "SELECT news_text FROM news_submission WHERE news_submission_id = ?",
                "i",
                $news_id
            );
        }

        \AL\Db\bind_result(
            "NewsSubmissionDAO: Get news text",
            $stmt,

The variable $stmt does not seem to be defined for all execution paths leading up to this point.

            $news
        );

        $stmt->fetch();
        $stmt->close();

        return $news;
    }
}