| Conditions | 11 |
| Paths | 21 |
| Total Lines | 63 |
| Code Lines | 38 |
| Lines | 29 |
| Ratio | 46.03 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 19 | public function run() |
||
| 20 | { |
||
| 21 | $this->loadGoogleSite(); |
||
| 22 | |||
| 23 | $exit = false; |
||
| 24 | $count = 0; |
||
| 25 | $paginator = ''; |
||
| 26 | $countProxyVirgin = rand(0, count($this->listOfVirginProxies) - 1); |
||
| 27 | $resultFinal = array(); |
||
| 28 | $countProxyFail = array(); |
||
| 29 | |||
| 30 | while ($exit == false) { |
||
|
|
|||
| 31 | if ($count != 0) { |
||
| 32 | $numPaginator = 100 * $count; |
||
| 33 | $paginator = '&start='.$numPaginator; |
||
| 34 | } |
||
| 35 | |||
| 36 | $urlOfSearch = 'https://'.$this->siteGoogle.'/search?q='.urlencode($this->commandData['dork']).'&num=100&btnG=Search&pws=1'.$paginator; |
||
| 37 | |||
| 38 | $this->output('Page '.$count."\n"); |
||
| 39 | |||
| 40 | View Code Duplication | if ($this->commandData['virginProxies']) { |
|
| 41 | $body = Utils::getBodyByVirginProxies($urlOfSearch, $this->listOfVirginProxies[$countProxyVirgin], $this->proxy); |
||
| 42 | |||
| 43 | //Check if exist captcha |
||
| 44 | //Check if next group of return data or not |
||
| 45 | $arrLinks = array(); |
||
| 46 | if (!$this->checkCaptcha($body) and $body != 'repeat') { |
||
| 47 | $arrLinks = Utils::getLinks($body); |
||
| 48 | } else { |
||
| 49 | --$count; |
||
| 50 | $countProxyFail[$countProxyVirgin] = $this->listOfVirginProxies[$countProxyVirgin]; |
||
| 51 | |||
| 52 | $this->output("You has a problem with proxy, probaly you estress the engenier ...\n"); |
||
| 53 | } |
||
| 54 | |||
| 55 | //Check if next virgin proxy or repeat of 0 |
||
| 56 | if ($countProxyVirgin == count($this->listOfVirginProxies) - 1) { |
||
| 57 | $countProxyVirgin = 0; |
||
| 58 | } else { |
||
| 59 | ++$countProxyVirgin; |
||
| 60 | } |
||
| 61 | } else { |
||
| 62 | $body = $this->getBody($urlOfSearch); |
||
| 63 | $arrLinks = Utils::getLinks($body); |
||
| 64 | } |
||
| 65 | |||
| 66 | $this->output("\n".$urlOfSearch."\n"); |
||
| 67 | |||
| 68 | $results = Utils::sanitazeLinks($arrLinks); |
||
| 69 | |||
| 70 | View Code Duplication | if (((count($results) == 0 && $body != 'repeat') && !$this->checkCaptcha($body)) |
|
| 71 | || (count($countProxyFail) == count($this->listOfVirginProxies))) { |
||
| 72 | $exit = true; |
||
| 73 | } |
||
| 74 | |||
| 75 | $resultFinal = array_merge($resultFinal, $results); |
||
| 76 | |||
| 77 | ++$count; |
||
| 78 | } |
||
| 79 | |||
| 80 | return $resultFinal; |
||
| 81 | } |
||
| 82 | |||
| 114 |
When comparing two booleans, it is generally considered safer to use the strict comparison operator.