Conditions | 3 |
Paths | 2 |
Total Lines | 13 |
Code Lines | 7 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
1 | <?php |
||
45 | public function validate() |
||
46 | { |
||
47 | if ($this->commandData['virginProxies'] && !$this->proxies->checkVirginProxiesExist()) { |
||
48 | $error['type'] = 'vp'; |
||
|
|||
49 | $error['result'] = 'There is no list of botnets Virgin Proxy'; |
||
50 | |||
51 | $this->error = $error; |
||
52 | |||
53 | return false; |
||
54 | } |
||
55 | |||
56 | return true; |
||
57 | } |
||
58 | |||
80 |
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArray
is initialized the first time when the foreach loop is entered. You can also see that the value of thebar
key is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.