Conditions | 5 |
Paths | 16 |
Total Lines | 21 |
Code Lines | 11 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
1 | <?php |
||
23 | public function __construct(array $data) |
||
24 | { |
||
25 | $this->commandData = array_merge($this->defaultCommandData, $data); |
||
26 | |||
27 | if ($this->hasProxy()) { |
||
28 | $this->proxies = new Proxies(); |
||
29 | } |
||
30 | |||
31 | if ($this->commandData['tor']) { |
||
32 | $this->proxy = $this->proxies->getTor(); |
||
33 | } |
||
34 | |||
35 | if ($this->commandData['proxyOfSites']) { |
||
36 | $this->proxy = $this->proxies->getProxyOfSites(); |
||
37 | } |
||
38 | |||
39 | if ($this->commandData['virginProxies']) { |
||
40 | $this->listOfVirginProxies = $this->proxies->getVirginSiteProxies(); |
||
41 | $this->usingVirginProxies = true; |
||
42 | } |
||
43 | } |
||
44 | |||
80 |
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArray
is initialized the first time when the foreach loop is entered. You can also see that the value of thebar
key is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.