Bing::run() - Code Metrics - aszone/search-hacking - Measure and Improve Code Quality continuously with Scrutinizer

Bing::run() B
last analyzed 2016-10-21 02:13 UTC

↳ Parent: Bing

Complexity

Conditions	8
Paths	13

Size

Total Lines	56
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	56
rs	7.3333
c	0
b	0
f	0
cc	8
eloc	33
nc	13
nop	0

How to fix Long Method

<?php
/**
 * Created by PhpStorm.
 * User: lenon
 * Date: 23/04/16
 * Time: 01:43.
 */

namespace Aszone\SearchHacking\Engines;

use Aszone\SearchHacking\Utils;

class Bing extends Engine
{
    public function run()
    {
        $exit = false;
        $count = 0;
        $numPaginator = 0;
        $countProxyVirgin = rand(0, count($this->listOfVirginProxies) - 1);
        $resultFinal = array();
        $totalOutProxy = 5;
        $countOutProxy = 0;

        while ($exit == false) {

            if ($count != 0) {
                $numPaginator = 10 * $count;
            }

            $urlOfSearch = 'http://www.bing.com/search?q='.urlencode($this->commandData['dork']).'&filt=rf&first='.$numPaginator;

            $this->output('Page '.$count."\n");

            if ($this->commandData['virginProxies']) {
                $this->output('*'.$countProxyVirgin.'*');

                $this->output('&'.$this->listOfVirginProxies[$countProxyVirgin].'&');

                $body = Utils::getBodyByVirginProxies($urlOfSearch, $this->listOfVirginProxies[$countProxyVirgin], $this->proxy);

                $arrLinks = Utils::getLinks($body);

                //Check if next virgin proxy or repeat of 0
                if ($countProxyVirgin == count($this->listOfVirginProxies) - 1) {
                    $countProxyVirgin = 0;
                } else {
                    ++$countProxyVirgin;
                }
            } else {
                $body = Utils::getBody($urlOfSearch, $this->proxy);

                $arrLinks = Utils::getLinks($body);

                ++$countOutProxy;
            }

            $this->output("\n".$urlOfSearch."\n");

            $results = Utils::sanitazeLinks($arrLinks);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            if ((count($results) == 0 && $body != 'repeat') || ($countOutProxy == $totalOutProxy)) {
                $exit = true;
            }

            $resultFinal = array_merge($resultFinal, $results);
            ++$count;
        }

        return $resultFinal;
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: lenon
5			* Date: 23/04/16
6			* Time: 01:43.
7			*/
8
9			namespace Aszone\SearchHacking\Engines;
10
11			use Aszone\SearchHacking\Utils;
12
13			class Bing extends Engine
14			{
15			public function run()
16			{
17			$exit = false;
18			$count = 0;
19			$numPaginator = 0;
20			$countProxyVirgin = rand(0, count($this->listOfVirginProxies) - 1);
21			$resultFinal = array();
22			$totalOutProxy = 5;
23			$countOutProxy = 0;
24
25			while ($exit == false) {
			0 ignored issues – show Coding Style Best Practice introduced 2016-10-19 13:01 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
26			if ($count != 0) {
27			$numPaginator = 10 * $count;
28			}
29
30			$urlOfSearch = 'http://www.bing.com/search?q='.urlencode($this->commandData['dork']).'&filt=rf&first='.$numPaginator;
31
32			$this->output('Page '.$count."\n");
33
34			if ($this->commandData['virginProxies']) {
35			$this->output(''.$countProxyVirgin.'');
36
37			$this->output('&'.$this->listOfVirginProxies[$countProxyVirgin].'&');
38
39			$body = Utils::getBodyByVirginProxies($urlOfSearch, $this->listOfVirginProxies[$countProxyVirgin], $this->proxy);
40
41			$arrLinks = Utils::getLinks($body);
42
43			//Check if next virgin proxy or repeat of 0
44			if ($countProxyVirgin == count($this->listOfVirginProxies) - 1) {
45			$countProxyVirgin = 0;
46			} else {
47			++$countProxyVirgin;
48			}
49			} else {
50			$body = Utils::getBody($urlOfSearch, $this->proxy);
51
52			$arrLinks = Utils::getLinks($body);
53
54			++$countOutProxy;
55			}
56
57			$this->output("\n".$urlOfSearch."\n");
58
59			$results = Utils::sanitazeLinks($arrLinks);
			0 ignored issues – show Documentation introduced 2016-10-19 13:01 UTC by Report Bug Copy Issue Report `$arrLinks` is of type `object<Symfony\Component\DomCrawler\Crawler>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
60
61			if ((count($results) == 0 && $body != 'repeat') \|\| ($countOutProxy == $totalOutProxy)) {
62			$exit = true;
63			}
64
65			$resultFinal = array_merge($resultFinal, $results);
66			++$count;
67			}
68
69			return $resultFinal;
70			}
71			}
72

aszone / search-hacking

Bing::run() B last analyzed 2016-10-21 02:13 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

Bing::run() B
last analyzed 2016-10-21 02:13 UTC