ConnectorFactory::validate() - Code Metrics - Inspection of "Added blocking connector" - asyncphp/icicle-database - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Christopher

created 2015-12-22 06:42 UTC

ConnectorFactory::validate() B

↳ Parent: ConnectorFactory

Complexity

Conditions	5
Paths	5

Size

Total Lines	20
Code Lines	10

Duplication

Lines	3
Ratio	15 %

Code Coverage

Tests	6
CRAP Score	6.6

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	3
loc	20
ccs	6
cts	10
cp	0.6
rs	8.8571
cc	5
eloc	10
nc	5
nop	1
crap	6.6

<?php

namespace AsyncPHP\Icicle\Database;

use AsyncPHP\Icicle\Database\Connector\BlockingConnector;
use AsyncPHP\Icicle\Database\Connector\DoormanConnector;
use InvalidArgumentException;

final class ConnectorFactory
{
    /**
     * @param array $config
     *
     * @return Connector
     *
     * @throws InvalidArgumentException
     */
    public function create(array $config)
    {
        $config = $this->validate($config);

        if ($config["connector"] === "doorman") {
            $connector = new DoormanConnector();
        }

        if ($config["connector"] === "blocking") {
            $connector = new BlockingConnector();
        }

        $connector->connect($config);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        return $connector;
    }

    /**
     * @param array $config
     *
     * @return array
     *
     * @throws InvalidArgumentException
     */
    private function validate(array $config)
    {
        if (!isset($config["driver"])) {
            throw new InvalidArgumentException("Undefined driver");
        }

        if (!in_array($config["driver"], ["sqlsrv", "mysql", "pgsql", "sqlite"])) {

            throw new InvalidArgumentException("Unrecognised driver");
        }

        if (!isset($config["connector"])) {
            throw new InvalidArgumentException("Undefined connector");
        }

        if (!in_array($config["connector"], ["doorman", "blocking"])) {
            throw new InvalidArgumentException("Unrecognised connector");
        }

        return $config;
    }
}


1			<?php
2
3			namespace AsyncPHP\Icicle\Database;
4
5			use AsyncPHP\Icicle\Database\Connector\BlockingConnector;
6			use AsyncPHP\Icicle\Database\Connector\DoormanConnector;
7			use InvalidArgumentException;
8
9			final class ConnectorFactory
10			{
11			/**
12			* @param array $config
13			*
14			* @return Connector
15			*
16			* @throws InvalidArgumentException
17			*/
18	2		public function create(array $config)
19			{
20	2		$config = $this->validate($config);
21
22	2		if ($config["connector"] === "doorman") {
23	1		$connector = new DoormanConnector();
24	1		}
25
26	2		if ($config["connector"] === "blocking") {
27	1		$connector = new BlockingConnector();
28	1		}
29
30	2		$connector->connect($config);
			0 ignored issues – show Bug introduced 2015-12-22 06:44 UTC by Report Bug Copy Issue Report The variable `$connector` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
31
32	2		return $connector;
33			}
34
35			/**
36			* @param array $config
37			*
38			* @return array
39			*
40			* @throws InvalidArgumentException
41			*/
42	2		private function validate(array $config)
43			{
44	2		if (!isset($config["driver"])) {
45			throw new InvalidArgumentException("Undefined driver");
46			}
47
48	2	View Code Duplication	if (!in_array($config["driver"], ["sqlsrv", "mysql", "pgsql", "sqlite"])) {
			0 ignored issues – show Duplication introduced 2015-12-02 08:17 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49			throw new InvalidArgumentException("Unrecognised driver");
50			}
51
52	2		if (!isset($config["connector"])) {
53			throw new InvalidArgumentException("Undefined connector");
54			}
55
56	2		if (!in_array($config["connector"], ["doorman", "blocking"])) {
57			throw new InvalidArgumentException("Unrecognised connector");
58			}
59
60	2		return $config;
61			}
62			}
63

asyncphp / icicle-database

Pull Request — master (#1)

ConnectorFactory::validate() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like