DoormanConnectorHandler::handle() - Code Metrics - Inspection of "Added try-catch around pdo disconnect" - asyncphp/icicle-database - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 429f1a...51eb75 )

by Christopher

created 2015-12-06 22:54 UTC

DoormanConnectorHandler::handle() B

↳ Parent: DoormanConnectorHandler

Complexity

Conditions	4
Paths	4

Size

Total Lines	66
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	3
Bugs	0	Features	2

Metric	Value
c	3
b	0
f	2
dl	0
loc	66
ccs	0
cts	50
cp	0
rs	8.8291
cc	4
eloc	36
nc	4
nop	1
crap	20

How to fix Long Method

<?php

namespace AsyncPHP\Icicle\Database\Connector;

use AsyncPHP\Doorman\Handler;
use AsyncPHP\Doorman\Task;
use AsyncPHP\Remit\Client;
use AsyncPHP\Remit\Client\ZeroMqClient;
use AsyncPHP\Remit\Location\InMemoryLocation;
use AsyncPHP\Remit\Server;
use AsyncPHP\Remit\Server\ZeroMqServer;
use Aura\Sql\ExtendedPdo;
use Icicle\Loop;
use PDO;

final class DoormanConnectorHandler implements Handler
{
    /**
     * @inheritdoc
     *
     * @param Task $task
     */
    public function handle(Task $task)
    {
        $config = $task->getData();

        if ($config["driver"] === "mysql") {
            $config += [
                "host" => "127.0.0.1",
                "port" => 3306,
                "charset" => "utf8",
                "socket" => null,
            ];
        }

        if ($config["remit"]["driver"] === "zeromq") {
            $config["remit"]["server"] += [
                "host" => "127.0.0.1",
            ];

            $config["remit"]["client"] += [
                "host" => "127.0.0.1",
            ];

            $server = new ZeroMqServer(
                new InMemoryLocation(
                    $config["remit"]["client"]["host"],
                    $config["remit"]["client"]["port"]
                )
            );

            $client = new ZeroMqClient(
                new InMemoryLocation(
                    $config["remit"]["server"]["host"],
                    $config["remit"]["server"]["port"]
                )
            );
        }

        $connection = new ExtendedPdo(
            new PDO($this->newConnectionString($config), $config["username"], $config["password"])
        );

        $server->addListener("q", function ($query, $values, $id) use ($client, $connection) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            $client->emit("r", [$connection->fetchAll($query, $values), $id]);
        });

        $server->addListener("d", function () use ($connection, $server, $client) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            $client->emit("dd");

            try {
                $connection->disconnect();
            } catch (Exception $exception) {

                // TODO: find an elegant way to deal with this
            }

            $server->disconnect();
            $client->disconnect();

            Loop\stop();
        });

        Loop\periodic(0, function () use ($server) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            $server->tick();
        });

        Loop\run();
    }

    /**
     * Returns a new dsn string, for PDO to connect to the database with.
     *
     * @param array $config
     *
     * @return string
     */
    private function newConnectionString(array $config)
    {
        if ($config["driver"] === "mysql") {
            return "mysql:host={$config['host']};port={$config['port']};dbname={$config['schema']};unix_socket={$config['socket']};charset={$config['charset']}";
        }

        if ($config["driver"] === "pgsql") {
            return "pgsql:host={$config['host']};port={$config['port']};dbname={$config['schema']}";
        }

        if ($config["driver"] === "sqlite") {
            return "sqlite:{$config['file']}";
        }

        if ($config["driver"] === "sqlsrv") {
            return "sqlsrv:Server={$config['host']},{$config['port']};Database={$config['schema']}";
        }
    }
}


Push — master ( 429f1a...51eb75 )

DoormanConnectorHandler::handle() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace AsyncPHP\Icicle\Database\Connector;
4
5			use AsyncPHP\Doorman\Handler;
6			use AsyncPHP\Doorman\Task;
7			use AsyncPHP\Remit\Client;
8			use AsyncPHP\Remit\Client\ZeroMqClient;
9			use AsyncPHP\Remit\Location\InMemoryLocation;
10			use AsyncPHP\Remit\Server;
11			use AsyncPHP\Remit\Server\ZeroMqServer;
12			use Aura\Sql\ExtendedPdo;
13			use Icicle\Loop;
14			use PDO;
15
16			final class DoormanConnectorHandler implements Handler
17			{
18			/**
19			* @inheritdoc
20			*
21			* @param Task $task
22			*/
23			public function handle(Task $task)
24			{
25			$config = $task->getData();
26
27			if ($config["driver"] === "mysql") {
28			$config += [
29			"host" => "127.0.0.1",
30			"port" => 3306,
31			"charset" => "utf8",
32			"socket" => null,
33			];
34			}
35
36			if ($config["remit"]["driver"] === "zeromq") {
37			$config["remit"]["server"] += [
38			"host" => "127.0.0.1",
39			];
40
41			$config["remit"]["client"] += [
42			"host" => "127.0.0.1",
43			];
44
45			$server = new ZeroMqServer(
46			new InMemoryLocation(
47			$config["remit"]["client"]["host"],
48			$config["remit"]["client"]["port"]
49			)
50			);
51
52			$client = new ZeroMqClient(
53			new InMemoryLocation(
54			$config["remit"]["server"]["host"],
55			$config["remit"]["server"]["port"]
56			)
57			);
58			}
59
60			$connection = new ExtendedPdo(
61			new PDO($this->newConnectionString($config), $config["username"], $config["password"])
62			);
63
64			$server->addListener("q", function ($query, $values, $id) use ($client, $connection) {
			0 ignored issues – show Bug introduced 2015-12-03 03:07 UTC by Report Bug Copy Issue Report The variable `$server` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Bug introduced 2015-12-03 03:07 UTC by Report Bug Copy Issue Report The variable `$client` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
65			$client->emit("r", [$connection->fetchAll($query, $values), $id]);
66			});
67
68			$server->addListener("d", function () use ($connection, $server, $client) {
			0 ignored issues – show Bug introduced 2015-12-06 22:20 UTC by Report Bug Copy Issue Report The variable `$server` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Bug introduced 2015-12-06 22:20 UTC by Report Bug Copy Issue Report The variable `$client` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
69			$client->emit("dd");
70
71			try {
72			$connection->disconnect();
73			} catch (Exception $exception) {
			0 ignored issues – show Bug introduced 2015-12-06 22:56 UTC by Report Bug Copy Issue Report The class `AsyncPHP\Icicle\Database\Connector\Exception` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
74			// TODO: find an elegant way to deal with this
75			}
76
77			$server->disconnect();
78			$client->disconnect();
79
80			Loop\stop();
81			});
82
83			Loop\periodic(0, function () use ($server) {
			0 ignored issues – show Bug introduced 2015-12-03 03:07 UTC by Report Bug Copy Issue Report The variable `$server` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
84			$server->tick();
85			});
86
87			Loop\run();
88			}
89
90			/**
91			* Returns a new dsn string, for PDO to connect to the database with.
92			*
93			* @param array $config
94			*
95			* @return string
96			*/
97			private function newConnectionString(array $config)
98			{
99			if ($config["driver"] === "mysql") {
100			return "mysql:host={$config['host']};port={$config['port']};dbname={$config['schema']};unix_socket={$config['socket']};charset={$config['charset']}";
101			}
102
103			if ($config["driver"] === "pgsql") {
104			return "pgsql:host={$config['host']};port={$config['port']};dbname={$config['schema']}";
105			}
106
107			if ($config["driver"] === "sqlite") {
108			return "sqlite:{$config['file']}";
109			}
110
111			if ($config["driver"] === "sqlsrv") {
112			return "sqlsrv:Server={$config['host']},{$config['port']};Database={$config['schema']}";
113			}
114			}
115			}
116

asyncphp / icicle-database

Push — master ( 429f1a...51eb75 )

DoormanConnectorHandler::handle() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like