Issues in Accountant.php (master) - Issues in master - assimtech/money - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Accountant.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Assimtech\Money;

use InvalidArgumentException;

class Accountant
{
    /**
     * @param Money $money1
     * @param Money $money2
     * @throws InvalidArgumentException
     */
    protected function checkCurrenciesMatch(Money $money1, Money $money2)
    {
        if ($money1->getCurrency()->getCode() !== $money2->getCurrency()->getCode()) {
            throw new InvalidArgumentException(sprintf(
                'Cannot work with monies of differing currencies (%s, %s)',
                $money1,
                $money2
            ));
        }
    }

    /**
     * $money1 + $money2
     *
     * @param Money $money1
     * @param Money $money2
     * @return Money
     */
    public function add(Money $money1, Money $money2)

    {
        $this->checkCurrenciesMatch($money1, $money2);

        return new Money(
            $money1->getAmount() + $money2->getAmount(),
            $money1->getCurrency()
        );
    }

    /**
     * $money1 - $money2
     *
     * @param Money $money1
     * @param Money $money2
     * @return Money
     */
    public function subtract(Money $money1, Money $money2)

    {
        $this->checkCurrenciesMatch($money1, $money2);

        return new Money(
            $money1->getAmount() - $money2->getAmount(),
            $money1->getCurrency()
        );
    }

    /**
     * $money * $fraction
     *
     * @param Money $money
     * @param float|integer $fraction
     * @return Money
     */
    public function multiply(Money $money, $fraction)
    {
        return new Money(
            $money->getAmount() * $fraction,
            $money->getCurrency()
        );
    }

    /**
     * $money / $fraction
     *
     * @param Money $money
     * @param float|integer $fraction
     * @return Money
     */
    public function divide(Money $money, $fraction)
    {
        return new Money(
            $money->getAmount() / $fraction,
            $money->getCurrency()
        );
    }

    /**
     * @param Money[] $monies
     * @return Money|null
     */
    public function sum(array $monies)
    {
        $totalMoney = null;

        foreach ($monies as $money) {
            if (!$money instanceof Money) {
                throw new InvalidArgumentException('$monies must be an array of Money');
            }

            if ($totalMoney === null) {
                $totalMoney = clone $money;

                continue;
            }

            $totalMoney = $this->add($totalMoney, $money);
        }

        return $totalMoney;
    }
}


1			<?php
2
3			namespace Assimtech\Money;
4
5			use InvalidArgumentException;
6
7			class Accountant
8			{
9			/**
10			* @param Money $money1
11			* @param Money $money2
12			* @throws InvalidArgumentException
13			*/
14	4		protected function checkCurrenciesMatch(Money $money1, Money $money2)
15			{
16	4		if ($money1->getCurrency()->getCode() !== $money2->getCurrency()->getCode()) {
17	1		throw new InvalidArgumentException(sprintf(
18	1		'Cannot work with monies of differing currencies (%s, %s)',
19	1		$money1,
20			$money2
21	1		));
22			}
23	3		}
24
25			/**
26			* $money1 + $money2
27			*
28			* @param Money $money1
29			* @param Money $money2
30			* @return Money
31			*/
32	3	View Code Duplication	public function add(Money $money1, Money $money2)
			0 ignored issues – show Duplication introduced 2016-05-29 22:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33			{
34	3		$this->checkCurrenciesMatch($money1, $money2);
35
36	2		return new Money(
37	2		$money1->getAmount() + $money2->getAmount(),
38	2		$money1->getCurrency()
39	2		);
40			}
41
42			/**
43			* $money1 - $money2
44			*
45			* @param Money $money1
46			* @param Money $money2
47			* @return Money
48			*/
49	1	View Code Duplication	public function subtract(Money $money1, Money $money2)
			0 ignored issues – show Duplication introduced 2016-05-29 22:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50			{
51	1		$this->checkCurrenciesMatch($money1, $money2);
52
53	1		return new Money(
54	1		$money1->getAmount() - $money2->getAmount(),
55	1		$money1->getCurrency()
56	1		);
57			}
58
59			/**
60			* $money * $fraction
61			*
62			* @param Money $money
63			* @param float\|integer $fraction
64			* @return Money
65			*/
66	1		public function multiply(Money $money, $fraction)
67			{
68	1		return new Money(
69	1		$money->getAmount() * $fraction,
70	1		$money->getCurrency()
71	1		);
72			}
73
74			/**
75			* $money / $fraction
76			*
77			* @param Money $money
78			* @param float\|integer $fraction
79			* @return Money
80			*/
81	1		public function divide(Money $money, $fraction)
82			{
83	1		return new Money(
84	1		$money->getAmount() / $fraction,
85	1		$money->getCurrency()
86	1		);
87			}
88
89			/**
90			* @param Money[] $monies
91			* @return Money\|null
92			*/
93	2		public function sum(array $monies)
94			{
95	2		$totalMoney = null;
96
97	2		foreach ($monies as $money) {
98	2		if (!$money instanceof Money) {
99	1		throw new InvalidArgumentException('$monies must be an array of Money');
100			}
101
102	1		if ($totalMoney === null) {
103	1		$totalMoney = clone $money;
104
105	1		continue;
106			}
107
108	1		$totalMoney = $this->add($totalMoney, $money);
109	1		}
110
111	1		return $totalMoney;
112			}
113			}
114

assimtech / money

Issues (2)

Security Analysis no request data

src/Accountant.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like