Module - Code Metrics - Inspection of "Added sorting sitemap by priority" - assayer-pro/yii2-sitemap-module - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#8)

unknown

created 2016-06-20 15:02 UTC

Module A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	4
Bugs	2	Features	2

Metric	Value
wmc	1
c	4
b	2
f	2
lcom	1
cbo	1
dl	0
loc	28
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	init()	0	7	1

<?php
/**
 * Sitemap module
 *
 * @author Serge Larin <[email protected]>
 * @link http://assayer.pro/
 * @copyright 2015 Assayer Pro Company
 * @license http://opensource.org/licenses/LGPL-3.0
 */


namespace assayerpro\sitemap;

/**
 * Class Module for sitemap
 *
 * @author Serge Larin <[email protected]>
 * @package app\modules\webmaster
 */
class Module extends \yii\base\Module
{
    public $cacheExpire = 0;
    public $enableGzip = false;
    protected $_components = [
        'generator' => [
            'class' => \assayerpro\sitemap\Sitemap::class,
        ],
    ];
    /**
     * The namespace that controller classes are in.
     *
     * @var string
     * @access public
     */
    public $controllerNamespace = 'assayerpro\sitemap\controllers';

    /**
     * @inheritdoc
     */
    public function init()
    {
        parent::init();
        $this->generator->moduleId = $this->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // custom initialization code goes here
    }
}


1			<?php
2			/**
3			* Sitemap module
4			*
5			* @author Serge Larin <[email protected]>
6			* @link http://assayer.pro/
7			* @copyright 2015 Assayer Pro Company
8			* @license http://opensource.org/licenses/LGPL-3.0
9			*/
10
11
12			namespace assayerpro\sitemap;
13
14			/**
15			* Class Module for sitemap
16			*
17			* @author Serge Larin <[email protected]>
18			* @package app\modules\webmaster
19			*/
20			class Module extends \yii\base\Module
21			{
22			public $cacheExpire = 0;
23			public $enableGzip = false;
24			protected $_components = [
25			'generator' => [
26			'class' => \assayerpro\sitemap\Sitemap::class,
27			],
28			];
29			/**
30			* The namespace that controller classes are in.
31			*
32			* @var string
33			* @access public
34			*/
35			public $controllerNamespace = 'assayerpro\sitemap\controllers';
36
37			/**
38			* @inheritdoc
39			*/
40			public function init()
41			{
42			parent::init();
43			$this->generator->moduleId = $this->id;
			0 ignored issues – show Documentation introduced 2016-06-17 12:18 UTC by Report Bug Copy Issue Report The property `generator` does not exist on `object<assayerpro\sitemap\Module>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
44
45			// custom initialization code goes here
46			}
47			}
48

assayer-pro / yii2-sitemap-module

Pull Request — master (#8)

Module A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like