ZendeskChannel::__construct() - Code Metrics - Inspection of "support route" - assaqqaf/zendesk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by Abdullah

created 2017-01-14 05:53 UTC

ZendeskChannel::__construct() A

↳ Parent: ZendeskChannel

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	3
cts	3
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace NotificationChannels\Zendesk;

use Zendesk\API\Client;
use Illuminate\Support\Arr;
use Illuminate\Notifications\Notification;
use NotificationChannels\Zendesk\Exceptions\CouldNotSendNotification;

class ZendeskChannel
{
    /** @var Client */
    protected $client;

    /** @param Client $client */
    public function __construct(Client $client)
    {
        $this->client = $client;
    }

    /**
     * Send the given notification.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @throws \NotificationChannels\Zendesk\Exceptions\InvalidConfiguration
     * @throws \NotificationChannels\Zendesk\Exceptions\CouldNotSendNotification
     */
    public function send($notifiable, Notification $notification)
    {
        $zendeskParameters = $notification->toZendesk($notifiable)->toArray();


        if (!isset($zendeskParameters['requester']['name']) || $zendeskParameters['requester']['name'] ==='') {
            $routing = collect($notifiable->routeNotificationFor('Zendesk'));
            if (! Arr::has($routing, ['name', 'email'])) {
                return;
            }

            $zendeskParameters['requester']['name'] = $routing['name'];
            $zendeskParameters['requester']['email'] = $routing['email'];
        }

        $response = $this->client->tickets()->create($zendeskParameters);

        if ($response->getStatusCode() !== 200) {
            throw CouldNotSendNotification::serviceRespondedWithAnError($response);
        }
    }
}


1		<?php
2
3		namespace NotificationChannels\Zendesk;
4
5		use Zendesk\API\Client;
6		use Illuminate\Support\Arr;
7		use Illuminate\Notifications\Notification;
8		use NotificationChannels\Zendesk\Exceptions\CouldNotSendNotification;
9
10		class ZendeskChannel
11		{
12		/** @var Client */
13		protected $client;
14
15		/** @param Client $client */
16	3	public function __construct(Client $client)
17		{
18	3	$this->client = $client;
19	3	}
20
21		/**
22		* Send the given notification.
23		*
24		* @param mixed $notifiable
25		* @param \Illuminate\Notifications\Notification $notification
26		*
27		* @throws \NotificationChannels\Zendesk\Exceptions\InvalidConfiguration
28		* @throws \NotificationChannels\Zendesk\Exceptions\CouldNotSendNotification
29		*/
30	3	public function send($notifiable, Notification $notification)
31		{
32	3	$zendeskParameters = $notification->toZendesk($notifiable)->toArray();
		1 ignored issue – show Bug introduced 2017-01-14 04:40 UTC by Report Bug Copy Issue Report The method `toZendesk()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
33
34	3	if (!isset($zendeskParameters['requester']['name']) \|\| $zendeskParameters['requester']['name'] ==='') {
35	1	$routing = collect($notifiable->routeNotificationFor('Zendesk'));
36	1	if (! Arr::has($routing, ['name', 'email'])) {
37		return;
38		}
39
40	1	$zendeskParameters['requester']['name'] = $routing['name'];
41	1	$zendeskParameters['requester']['email'] = $routing['email'];
42		}
43
44	3	$response = $this->client->tickets()->create($zendeskParameters);
45
46	3	if ($response->getStatusCode() !== 200) {
47	1	throw CouldNotSendNotification::serviceRespondedWithAnError($response);
48		}
49	2	}
50		}
51

assaqqaf / zendesk

Pull Request — master (#3)

ZendeskChannel::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like