NotificationChannels\Zendesk\ZendeskChannel

Complexity

Total Complexity

12

Size/Duplication

Total Lines	99
Duplicated Lines	20.2 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

84.85%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	send()	0	12	2
A	prepareUpdateParameters()	0	4	1
A	updateTicket()	10	10	2
A	createNewTicket()	10	10	2
A	prepareCreateParameter()	0	15	4

<?php

namespace NotificationChannels\Zendesk;

use Illuminate\Support\Arr;
use Zendesk\API\HttpClient;
use Illuminate\Notifications\Notification;
use NotificationChannels\Zendesk\Exceptions\CouldNotSendNotification;

class ZendeskChannel
{
    /** @var HttpClient */
    protected $client;

    /** @var array */
    protected $parameters;

    /** @param HttpClient $client */
    public function __construct(HttpClient $client)
    {
        $this->client = $client;
    }

    /**
     * Send the given notification.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @throws \NotificationChannels\Zendesk\Exceptions\InvalidConfiguration
     * @throws \NotificationChannels\Zendesk\Exceptions\CouldNotSendNotification
     */
    public function send($notifiable, Notification $notification)
    {
        $this->parameters = $notification->toZendesk($notifiable)->toArray();

The method toZendesk() does not seem to exist on object<Illuminate\Notifications\Notification>.

        $id = $this->parameters['ticket'];

        if (! is_null($id)) {
            return $this->updateTicket($id, $notifiable);
        }

        return $this->createNewTicket($notifiable);
    }

    /**
     * Send update ticket request.
     *
     * @param mixed $notifiable
     */
    private function updateTicket($id, $notifiable)

The parameter $notifiable is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $this->prepareUpdateParameters();

        try {
            $this->client->tickets()->update($id, $this->parameters);
        } catch (\Exception $e) {
            throw CouldNotSendNotification::serviceRespondedWithAnError($e->getMessage());
        }
    }

    /**
     * Send create ticket request.
     *
     * @param mixed $notifiable
     */
    private function createNewTicket($notifiable)

This method seems to be duplicated in your project.

    {
        $this->prepareCreateParameter($notifiable);

        try {
            $this->client->tickets()->create($this->parameters);
        } catch (\Exception $e) {
            throw CouldNotSendNotification::serviceRespondedWithAnError($e->getMessage());
        }
    }

    /**
     * Prepare the parameters before update request send.
     *
     * @param mixed $notifiable

There is no parameter named $notifiable. Was it maybe removed?

     */
    public function prepareUpdateParameters()
    {
        unset($this->parameters['subject'], $this->parameters['requester'], $this->parameters['description'], $this->parameters['ticket']);
    }

    /**
     * Prepare the parameters before create request send.
     *
     * @param mixed $notifiable
     */
    private function prepareCreateParameter($notifiable)
    {
        // Check if the requester data is not set
        if (! isset($this->parameters['requester']['name']) || $this->parameters['requester']['name'] === '') {
            $routing = collect($notifiable->routeNotificationFor('Zendesk'));
            if (! Arr::has($routing, ['name', 'email'])) {
                return;
            }

            $this->parameters['requester']['name'] = $routing['name'];
            $this->parameters['requester']['email'] = $routing['email'];
        }

        unset($this->parameters['ticket']);
    }
}