aspirantzhang\octopusRevision\command\Home

Complexity

Total Complexity

6

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	execute()	0	17	5
A	configure()	0	8	1

<?php

declare(strict_types=1);

namespace aspirantzhang\octopusRevision\command;

use think\console\Command;
use think\console\Input;
use think\console\input\Argument;
use think\console\Output;
use think\Exception;
use aspirantzhang\octopusRevision\RevisionAPI;

class Home extends Command
{
    protected function configure()
    {
        $this->setName('revision:list')
            ->addArgument('tableName', Argument::REQUIRED, "Table name")
            ->addArgument('recordId', Argument::REQUIRED, "Record Id")
            ->addArgument('page', Argument::OPTIONAL, "Current page number")
            ->addArgument('perPage', Argument::OPTIONAL, "Per page number")
            ->setDescription('Get the revision list of a specific record of a table');
    }

    protected function execute(Input $input, Output $output)
    {
        $output->writeln('<info>Processing...</info>');

        $tableName = trim($input->getArgument('tableName'));

It seems like $input->getArgument('tableName') can also be of type think\console\input\Argument; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

        $recordId = trim($input->getArgument('recordId'));
        $page = $input->getArgument('page') ? (int)trim($input->getArgument('page')) : null;
        $perPage = $input->getArgument('perPage') ? (int)trim($input->getArgument('perPage')) : null;

        $result = (new RevisionAPI())->listAPI($tableName, (int)$recordId, $page, $perPage);

It seems like $page can also be of type null; however, parameter $page of aspirantzhang\octopusRevision\RevisionAPI::listAPI() does only seem to accept integer, maybe add an additional type check?

It seems like $perPage can also be of type null; however, parameter $perPage of aspirantzhang\octopusRevision\RevisionAPI::listAPI() does only seem to accept integer, maybe add an additional type check?

        if ($result['success'] === true) {
            $list = $result['data']['dataSource'];
            foreach ($list as $item) {
                $output->writeln('<comment> - [' . $item['id'] . ']' . $item['title'] . ' @ ' . $item['create_time'] . '</comment>');
            }
        } else {
            $output->writeln('<error>' . $result['message'] . '</error>');
        }
    }
}