aspirantzhang\octopusRevision\command\Read

Complexity

Total Complexity

3

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	0	5	1
A	execute()	0	9	2

<?php

declare(strict_types=1);

namespace aspirantzhang\octopusRevision\command;

use think\console\Command;
use think\console\Input;
use think\console\input\Argument;
use think\console\Output;
use aspirantzhang\octopusRevision\RevisionAPI;

class Read extends Command
{
    protected function configure()
    {
        $this->setName('revision:read')
        ->addArgument('revisionId', Argument::REQUIRED, "Revision id")
        ->setDescription('View the details of a revision');
    }

    protected function execute(Input $input, Output $output)
    {
        $revisionId = trim($input->getArgument('revisionId'));

It seems like $input->getArgument('revisionId') can also be of type think\console\input\Argument; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

        $result = (new RevisionAPI())->readAPI((int)$revisionId);
        if ($result['success'] === true) {
            $output->writeln('<comment>' . print_r($result['data']['dataSource']) . '</comment>');

Are you sure print_r($result['data']['dataSource']) of type string|true can be used in concatenation?

        } else {
            $output->writeln('<error>' . $result['message'] . '</error>');
        }
    }
}