Issues in functions.php - Fixed Issues - Inspection of "Improved comments and logic" - askupasoftware/wp-dynamic-css - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 61806a...459bf7 )

by Askupa

created 2016-08-06 00:47 UTC

functions.php (2 issues)

Labels

Documentation 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @package   WordPress Dynamic CSS
 * @version   1.0.5
 * @author    Askupa Software <[email protected]>
 * @link      https://github.com/askupasoftware/wp-dynamic-css
 * @copyright 2016 Askupa Software
 */

if( !function_exists('wp_dynamic_css_enqueue') )
{
    /**
     * Enqueue a dynamic stylesheet
     * 
     * This will either print the compiled version of the stylesheet to the 
     * document's <head> section, or load it as an external stylesheet if $print 
     * is set to false
     * 
     * @param string $handle The stylesheet's name/id
     * @param string $path The absolute path to the dynamic CSS file
     * @paran boolean $print Whether to print the compiled CSS to the document 
     * head, or include it as an external CSS file
     * @param boolean $minify Whether to minify the CSS output
     * @param boolean $cache Whether to store the compiled version of this 
     * stylesheet in cache to avoid compilation on every page load.
     */
    function wp_dynamic_css_enqueue( $handle, $path, $print = true, $minify = false, $cache = false )
    {
        $dcss = DynamicCSSCompiler::get_instance();
        $dcss->register_style( $handle, $path, $print, $minify, $cache );
    }
}

if( !function_exists('wp_dynamic_css_set_callback') )
{
    /**
     * Set the value retrieval callback function
     * 
     * Set a callback function that will be used to get the values of the 
     * variables when the dynamic CSS file is compiled. The function accepts 1 
     * parameter which is the name of the variable, without the $ sign
     * 
     * @param string $handle The name of the stylesheet to be associated with this
     * callback function
     * @param string|array $callback A callback (or "callable" as of PHP 5.4) 
     * can either be a reference to a function name or method within an 
     * class/object.
     */
    function wp_dynamic_css_set_callback( $handle, $callback )
    {
        $dcss = DynamicCSSCompiler::get_instance();
        $dcss->register_callback( $handle, $callback );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}

if( !function_exists('wp_dynamic_css_clear_cache') )
{
    /**
     * Clear the cached compiled CSS for the given handle.
     * 
     * Registered dynamic stylesheets that have the $cache flag set to true are
     * compiled only once and then stored in cache. Subsequesnt requests are 
     * served statically from cache until wp_dynamic_css_clear_cache() is called 
     * and clears it, forcing the compiler to recompile the CSS.
     * 
     * @param string $handle The name of the stylesheet to be cleared from cache
     */
    function wp_dynamic_css_clear_cache( $handle )
    {
        $cache = DynamicCSSCache::get_instance();
        $cache->clear( $handle );
    }
}

if( !function_exists('wp_dynamic_css_register_filter') )
{
    /**
     * Register a filter function for a given stylesheet handle.
     * 
     * For example, a registered filter named 'myFilter' can be used in a dynamic
     * CSS file like so:
     * 
     * <pre>
     * body {
     *     $myVar|myFilter
     * }
     * </pre>
     * 
     * Filters can also accept arguments:
     * 
     * <pre>
     * body {
     *     $myVar|myFilter('1',2,3.4)
     * }
     * </pre>
     * 
     * And can be stacked together:
     * 
     * <pre>
     * body {
     *     $myVar|myFilter1|filter2|filter3
     * }
     * </pre>
     * 
     * @param string $handle The handle of the stylesheet in which this filter 
     * is to be used.
     * @param string $filter_name The name of the filter to be used in the 
     * dynamic CSS file.
     * @param Callable $callback The actual filter function. Accepts the $value
     * as an argument. Should return the filtered value.
     */
    function wp_dynamic_css_register_filter( $handle, $filter_name, $callback )
    {
        $dcss = DynamicCSSCompiler::get_instance();
        $dcss->register_filter( $handle, $filter_name, $callback );
    }
}


1			<?php
2			/**
3			* @package WordPress Dynamic CSS
4			* @version 1.0.5
5			* @author Askupa Software <[email protected]>
6			* @link https://github.com/askupasoftware/wp-dynamic-css
7			* @copyright 2016 Askupa Software
8			*/
9
10			if( !function_exists('wp_dynamic_css_enqueue') )
11			{
12			/**
13			* Enqueue a dynamic stylesheet
14			*
15			* This will either print the compiled version of the stylesheet to the
16			* document's <head> section, or load it as an external stylesheet if $print
17			* is set to false
18			*
19			* @param string $handle The stylesheet's name/id
20			* @param string $path The absolute path to the dynamic CSS file
21			* @paran boolean $print Whether to print the compiled CSS to the document
22			* head, or include it as an external CSS file
23			* @param boolean $minify Whether to minify the CSS output
24			* @param boolean $cache Whether to store the compiled version of this
25			* stylesheet in cache to avoid compilation on every page load.
26			*/
27			function wp_dynamic_css_enqueue( $handle, $path, $print = true, $minify = false, $cache = false )
28			{
29			$dcss = DynamicCSSCompiler::get_instance();
30			$dcss->register_style( $handle, $path, $print, $minify, $cache );
31			}
32			}
33
34			if( !function_exists('wp_dynamic_css_set_callback') )
35			{
36			/**
37			* Set the value retrieval callback function
38			*
39			* Set a callback function that will be used to get the values of the
40			* variables when the dynamic CSS file is compiled. The function accepts 1
41			* parameter which is the name of the variable, without the $ sign
42			*
43			* @param string $handle The name of the stylesheet to be associated with this
44			* callback function
45			* @param string\|array $callback A callback (or "callable" as of PHP 5.4)
46			* can either be a reference to a function name or method within an
47			* class/object.
48			*/
49			function wp_dynamic_css_set_callback( $handle, $callback )
50			{
51			$dcss = DynamicCSSCompiler::get_instance();
52			$dcss->register_callback( $handle, $callback );
			0 ignored issues – show Documentation introduced 2016-08-05 15:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$handle` is of type `string`, but the function expects a `object<type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2016-08-05 15:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$callback` is of type `string\|array`, but the function expects a `object<type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
53			}
54			}
55
56			if( !function_exists('wp_dynamic_css_clear_cache') )
57			{
58			/**
59			* Clear the cached compiled CSS for the given handle.
60			*
61			* Registered dynamic stylesheets that have the $cache flag set to true are
62			* compiled only once and then stored in cache. Subsequesnt requests are
63			* served statically from cache until wp_dynamic_css_clear_cache() is called
64			* and clears it, forcing the compiler to recompile the CSS.
65			*
66			* @param string $handle The name of the stylesheet to be cleared from cache
67			*/
68			function wp_dynamic_css_clear_cache( $handle )
69			{
70			$cache = DynamicCSSCache::get_instance();
71			$cache->clear( $handle );
72			}
73			}
74
75			if( !function_exists('wp_dynamic_css_register_filter') )
76			{
77			/**
78			* Register a filter function for a given stylesheet handle.
79			*
80			* For example, a registered filter named 'myFilter' can be used in a dynamic
81			* CSS file like so:
82			*
83			* <pre>
84			* body {
85			* $myVar\|myFilter
86			* }
87			* </pre>
88			*
89			* Filters can also accept arguments:
90			*
91			* <pre>
92			* body {
93			* $myVar\|myFilter('1',2,3.4)
94			* }
95			* </pre>
96			*
97			* And can be stacked together:
98			*
99			* <pre>
100			* body {
101			* $myVar\|myFilter1\|filter2\|filter3
102			* }
103			* </pre>
104			*
105			* @param string $handle The handle of the stylesheet in which this filter
106			* is to be used.
107			* @param string $filter_name The name of the filter to be used in the
108			* dynamic CSS file.
109			* @param Callable $callback The actual filter function. Accepts the $value
110			* as an argument. Should return the filtered value.
111			*/
112			function wp_dynamic_css_register_filter( $handle, $filter_name, $callback )
113			{
114			$dcss = DynamicCSSCompiler::get_instance();
115			$dcss->register_filter( $handle, $filter_name, $callback );
116			}
117			}
118

GitHub Access Token became invalid

Push — master ( 61806a...459bf7 )

functions.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

askupasoftware / wp-dynamic-css

GitHub Access Token became invalid

Push — master ( 61806a...459bf7 )

functions.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like