Issues in renderer.php - All Issues - Inspection of "Update README.md" - askupasoftware/wp-dynamic-css - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4d0b19...8e967f )

by Askupa

created 2016-03-20 05:07 UTC

renderer.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @package   WordPress Dynamic CSS
 * @version   1.0.0
 * @author    Askupa Software <[email protected]>
 * @link      https://github.com/askupasoftware/wp-dynamic-css
 * @copyright 2016 Askupa Software
 */

/**
 * Dynamic CSS Renderer Utility Class
 * 
 * 
 * Dynamic CSS Syntax
 * ------------------
 * <pre>
 * body {color: $body_color;} 
 * </pre>
 * In the above example, the variable $body_color is replaced by a value 
 * that is retrieved by the filter wp_dynamic_css_get_variable_value. The filter 
 * is passed the variable name without the dollar sign, which can be used with
 * get_option() or get_theme_mod() etc.
 */
class DynamicCSSRenderer
namespace YourVendor;

class YourClass { }
{
    /**
     * @var Singleton The reference to *Singleton* instance of this class
     */
    private static $instance;
    
    /**
     * @var array The list of dynamic styles paths to render
     */
    private $styles = array();
    
    /**
     * Returns the *Singleton* instance of this class.
     *
     * @return Singleton The *Singleton* instance.
     */
    public static function get_instance()
    {
        if (null === static::$instance) 
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        {
            static::$instance = new static();
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            static::$instance->init();
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        }
        
        return static::$instance;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
    }
    
    /**
     * Initiate the renderer by hooking to wp_print_styles
     */
    public function init()
    {
        add_action( 'wp_print_styles', array( $this, 'print_rendered_style' ) );
    }
    
    /**
     * Add a style path to the pool of styles to be rendered
     * 
     * @param type $path The absolute path to the dynamic style
     */
    public function enqueue_style( $path )
    {
        $this->styles[] = $path;
    }
    
    /**
     * Parse all styles in $this->styles and print them
     */
    public function print_rendered_style()
    {
        ob_start();
        foreach( $this->styles as $style ) 
        {
            include $style;
            echo "\n";
        }
        $css = $this->parse_css( ob_get_clean() );
        include 'style.phtml';
    }
    
    /**
     * Parse the given CSS string by converting the variables to their 
     * corresponding values retrieved by applying the filter 
     * wp_dynamic_css_get_variable_value.
     * 
     * @param string $css A string containing dynamic CSS (pre-rendered CSS with 
     * variables)
     * @uses wp_dynamic_css_get_variable_value filter
     * @return string The rendered CSS after converting the variables to their 
     * corresponding values
     */
    public function parse_css( $css )
    {   
        return preg_replace_callback('#\$([\w]+)#', function($matches) {
            return apply_filters( 'wp_dynamic_css_get_variable_value', $matches[1]);
        }, $css);
    }
}

1			<?php
2			/**
3			* @package WordPress Dynamic CSS
4			* @version 1.0.0
5			* @author Askupa Software <[email protected]>
6			* @link https://github.com/askupasoftware/wp-dynamic-css
7			* @copyright 2016 Askupa Software
8			*/
9
10			/**
11			* Dynamic CSS Renderer Utility Class
12			*
13			*
14			* Dynamic CSS Syntax
15			* ------------------
16			* <pre>
17			* body {color: $body_color;}
18			* </pre>
19			* In the above example, the variable $body_color is replaced by a value
20			* that is retrieved by the filter wp_dynamic_css_get_variable_value. The filter
21			* is passed the variable name without the dollar sign, which can be used with
22			* get_option() or get_theme_mod() etc.
23			*/
24			class DynamicCSSRenderer
			0 ignored issues – show Coding Style Compatibility introduced 2016-03-20 04:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
25			{
26			/**
27			* @var Singleton The reference to Singleton instance of this class
28			*/
29			private static $instance;
30
31			/**
32			* @var array The list of dynamic styles paths to render
33			*/
34			private $styles = array();
35
36			/**
37			* Returns the Singleton instance of this class.
38			*
39			* @return Singleton The Singleton instance.
40			*/
41			public static function get_instance()
42			{
43			if (null === static::$instance)
			0 ignored issues – show Bug introduced 2016-03-20 04:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
44			{
45			static::$instance = new static();
			0 ignored issues – show Bug introduced 2016-03-20 04:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history... Documentation Bug introduced 2016-03-20 04:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `new static()` of type `this<DynamicCSSRenderer>` is incompatible with the declared type `object<Singleton>` of property `$instance`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
46			static::$instance->init();
			0 ignored issues – show Bug introduced 2016-03-20 04:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
47			}
48
49			return static::$instance;
			0 ignored issues – show Bug introduced 2016-03-20 04:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history... Bug Compatibility introduced 2016-03-20 04:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `static::$instance;` of type `DynamicCSSRenderer\|Singleton` adds the type `DynamicCSSRenderer` to the return on line 49 which is incompatible with the return type documented by `DynamicCSSRenderer::get_instance` of type `Singleton`. Loading history...
50			}
51
52			/**
53			* Initiate the renderer by hooking to wp_print_styles
54			*/
55			public function init()
56			{
57			add_action( 'wp_print_styles', array( $this, 'print_rendered_style' ) );
58			}
59
60			/**
61			* Add a style path to the pool of styles to be rendered
62			*
63			* @param type $path The absolute path to the dynamic style
64			*/
65			public function enqueue_style( $path )
66			{
67			$this->styles[] = $path;
68			}
69
70			/**
71			* Parse all styles in $this->styles and print them
72			*/
73			public function print_rendered_style()
74			{
75			ob_start();
76			foreach( $this->styles as $style )
77			{
78			include $style;
79			echo "\n";
80			}
81			$css = $this->parse_css( ob_get_clean() );
82			include 'style.phtml';
83			}
84
85			/**
86			* Parse the given CSS string by converting the variables to their
87			* corresponding values retrieved by applying the filter
88			* wp_dynamic_css_get_variable_value.
89			*
90			* @param string $css A string containing dynamic CSS (pre-rendered CSS with
91			* variables)
92			* @uses wp_dynamic_css_get_variable_value filter
93			* @return string The rendered CSS after converting the variables to their
94			* corresponding values
95			*/
96			public function parse_css( $css )
97			{
98			return preg_replace_callback('#\$([\w]+)#', function($matches) {
99			return apply_filters( 'wp_dynamic_css_get_variable_value', $matches[1]);
100			}, $css);
101			}
102			}

GitHub Access Token became invalid

Push — master ( 4d0b19...8e967f )

renderer.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

askupasoftware / wp-dynamic-css

GitHub Access Token became invalid

Push — master ( 4d0b19...8e967f )

renderer.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like