TcpServer::start() - Code Metrics - Inspection of "[WIP]feature(server): integrate tcp server and lis..." - asiries335/redis-streams-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#11)

by Sergey

created 2022-05-10 20:03 UTC

TcpServer::start() A

↳ Parent: TcpServer

Complexity

Conditions	3
Paths	2

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	10
c	1
b	0
f	0
nc	2
nop	0
dl	0
loc	17
ccs	0
cts	10
cp	0
crap	12
rs	9.9332

<?php

namespace Asiries335\redisSteamPhp\Server;

use Asiries335\redisSteamPhp\Consumer\ConsumerInterface;
use React\Socket\ConnectionInterface;

/**
 *
 */
class TcpServer implements ServerInterface
{

    private array $config;

    /**
     * @var \React\Socket\ServerInterface
     */
    private $tcpServer = null;


    /**
     * @var ConsumerInterface[]
     */
    private array $consumers;

    /**
     * @param array $config
     * @return void
     */
    public function setConfig(array $config): void {
        $this->config = $config;
    }

    /**
     * @return void
     */
    public function start(): void {
        if ($this->tcpServer !== null) {
            return;
        }

        $ip = $this->config['ip'] ?? '0.0.0.0';
        $port = $this->config['port'] ?? '2341';

        $this->tcpServer = new \React\Socket\TcpServer($ip . ':' . $port);

        $this->tcpServer->on('connection', function (ConnectionInterface $connection) {

            $connection->pipe($connection);

            $connection->on('data', function ($payload) {
                foreach ($this->consumers as $consumer) {
                    $consumer->handle($payload);
                }
            });
        });
    }

    /**
     * @return void
     */
    public function down(): void {
        $this->tcpServer->close();
    }

    /**
     * @param ConnectionInterface[] $consumers
     * @return void
     */
    public function setConsumers(array $consumers): void {
        $this->consumers = $consumers;

    }
}

1			<?php
2
3			namespace Asiries335\redisSteamPhp\Server;
4
5			use Asiries335\redisSteamPhp\Consumer\ConsumerInterface;
6			use React\Socket\ConnectionInterface;
7
8			/**
9			*
10			*/
11			class TcpServer implements ServerInterface
12			{
13
14			private array $config;
15
16			/**
17			* @var \React\Socket\ServerInterface
18			*/
19			private $tcpServer = null;
20
21
22			/**
23			* @var ConsumerInterface[]
24			*/
25			private array $consumers;
26
27			/**
28			* @param array $config
29			* @return void
30			*/
31			public function setConfig(array $config): void {
32			$this->config = $config;
33			}
34
35			/**
36			* @return void
37			*/
38			public function start(): void {
39			if ($this->tcpServer !== null) {
40			return;
41			}
42
43			$ip = $this->config['ip'] ?? '0.0.0.0';
44			$port = $this->config['port'] ?? '2341';
45
46			$this->tcpServer = new \React\Socket\TcpServer($ip . ':' . $port);
47
48			$this->tcpServer->on('connection', function (ConnectionInterface $connection) {
49
50			$connection->pipe($connection);
51
52			$connection->on('data', function ($payload) {
53			foreach ($this->consumers as $consumer) {
54			$consumer->handle($payload);
55			}
56			});
57			});
58			}
59
60			/**
61			* @return void
62			*/
63			public function down(): void {
64			$this->tcpServer->close();
65			}
66
67			/**
68			* @param ConnectionInterface[] $consumers
69			* @return void
70			*/
71			public function setConsumers(array $consumers): void {
72			$this->consumers = $consumers;
			0 ignored issues – show Documentation Bug introduced 2022-05-10 20:05 UTC by Report Bug Copy Issue Report It seems like `$consumers` of type `React\Socket\ConnectionInterface[]` is incompatible with the declared type `Asiries335\redisSteamPhp...mer\ConsumerInterface[]` of property `$consumers`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
73			}
74			}

asiries335 / redis-streams-php

Pull Request — master (#11)

TcpServer::start() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like