Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | View Code Duplication | class HasMany extends Properties |
|
|
|||
14 | { |
||
15 | /** |
||
16 | * Extended to also check for dirty states of has-many Collections. |
||
17 | * |
||
18 | * {@inheritDoc} |
||
19 | */ |
||
20 | public function areDirty() |
||
32 | |||
33 | /** |
||
34 | * Extended to also rollback changes of has-many collections. |
||
35 | * |
||
36 | * {@inheritDoc} |
||
37 | */ |
||
38 | public function rollback() |
||
48 | |||
49 | /** |
||
50 | * Overwritten to account for collection change sets. |
||
51 | * |
||
52 | * {@inheritDoc} |
||
53 | */ |
||
54 | public function calculateChangeSet() |
||
65 | } |
||
66 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.