As3\Modlr\Persister\MongoDb\StorageMetadataFactory

Complexity

Total Complexity

15

Size/Duplication

Total Lines	105
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	createInstance()	0	13	3
A	handleLoad()	0	6	2
A	handleValidate()	0	6	1
A	validateCollectionNaming()	0	13	2
A	validateDatabase()	0	7	4
A	validateIdStrategy()	0	8	2

<?php

namespace As3\Modlr\Persister\MongoDb;

use As3\Modlr\Exception\MetadataException;
use As3\Modlr\Metadata\EntityMetadata;
use As3\Modlr\Metadata\Interfaces\StorageLayerInterface;
use As3\Modlr\Metadata\Interfaces\StorageMetadataFactoryInterface;
use As3\Modlr\Util\EntityUtility;

/**
 * Creates MongoDb storage Metadata instances for use with metadata drivers.
 * Is also responsible for validating storage objects.
 *
 * @author Jacob Bare <jacob.bare@gmail.com>
 */
final class StorageMetadataFactory implements StorageMetadataFactoryInterface
{
    /**
     * @var EntityUtility
     */
    private $entityUtil;

    /**
     * Constructor.
     *
     * @param   EntityUtility   $entityUtl

There is no parameter named $entityUtl. Did you maybe mean $entityUtil?

     */
    public function __construct(EntityUtility $entityUtil)
    {
        $this->entityUtil = $entityUtil;
    }

    /**
     * {@inheritDoc}
     */
    public function createInstance(array $mapping)
    {
        $persistence = new StorageMetadata();

        if (isset($mapping['db'])) {
            $persistence->db = $mapping['db'];
        }

        if (isset($mapping['collection'])) {
            $persistence->collection = $mapping['collection'];
        }
        return $persistence;
    }

    /**
     * {@inheritDoc}
     */
    public function handleLoad(EntityMetadata $metadata)
    {
        if (null === $metadata->persistence->collection) {

Accessing collection on the interface As3\Modlr\Metadata\Interfaces\StorageLayerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            $metadata->persistence->collection = $metadata->type;

Accessing collection on the interface As3\Modlr\Metadata\Interfaces\StorageLayerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        }
    }

    /**
     * {@inheritDoc}
     */
    public function handleValidate(EntityMetadata $metadata)
    {
        $this->validateIdStrategy($metadata);
        $this->validateDatabase($metadata);
        $this->validateCollectionNaming($metadata);
    }



    /**
     * Validates that the collection naming is correct, based on entity format config.
     *
     * @param   EntityMetadata  $metadata
     * @throws  MetadataException
     */
    private function validateCollectionNaming(EntityMetadata $metadata)
    {
        $persistence = $metadata->persistence;
        if (false === $this->entityUtil->isEntityTypeValid($persistence->collection)) {

Accessing collection on the interface As3\Modlr\Metadata\Interfaces\StorageLayerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            throw MetadataException::invalidMetadata(
                $metadata->type,
                sprintf('The entity persistence collection "%s" is invalid based on the configured name format "%s"',
                        $persistence->collection,

Accessing collection on the interface As3\Modlr\Metadata\Interfaces\StorageLayerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

                        $this->entityUtil->getRestConfig()->getEntityFormat()
                )
            );
        }
    }

    /**
     * Validates that the proper database properties are set.
     *
     * @param   EntityMetadata  $metadata
     * @throws  MetadataException
     */
    private function validateDatabase(EntityMetadata $metadata)
    {
        $persistence = $metadata->persistence;
        if (false === $metadata->isChildEntity() && (empty($persistence->db) || empty($persistence->collection))) {

Accessing db on the interface As3\Modlr\Metadata\Interfaces\StorageLayerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing collection on the interface As3\Modlr\Metadata\Interfaces\StorageLayerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            throw MetadataException::invalidMetadata($metadata->type, 'The persistence database and collection names cannot be empty.');
        }
    }

    /**
     * Validates the proper id strategy.
     *
     * @param   EntityMetadata  $metadata
     * @throws  MetadataException
     */
    private function validateIdStrategy(EntityMetadata $metadata)
    {
        $persistence = $metadata->persistence;
        $validIdStrategies = ['object'];
        if (!in_array($persistence->idStrategy, $validIdStrategies)) {

Accessing idStrategy on the interface As3\Modlr\Metadata\Interfaces\StorageLayerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            throw MetadataException::invalidMetadata($metadata->type, sprintf('The persistence id strategy "%s" is invalid. Valid types are "%s"', $persistence->idStrategy, implode('", "', $validIdStrategies)));

Accessing idStrategy on the interface As3\Modlr\Metadata\Interfaces\StorageLayerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        }
    }
}