CursorRecordSet::totalCount() - Code Metrics - as3io/modlr-persister-mongodb - Measure and Improve Code Quality continuously with Scrutinizer

CursorRecordSet::totalCount() A
last analyzed 2016-10-03 17:32 UTC

↳ Parent: CursorRecordSet

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

namespace As3\Modlr\Persister\MongoDb;

use As3\Modlr\Metadata\EntityMetadata;
use As3\Modlr\Persister\RecordSetInterface;
use As3\Modlr\Store\Store;
use Doctrine\MongoDB\Cursor;

/**
 * Represents records from MongoDb via a Cursor.
 *
 * @author  Jacob Bare <[email protected]>
 */
class CursorRecordSet implements RecordSetInterface
{
    /**
     * @var Cursor
     */
    private $cursor;

    /**
     * @var Hydrator
     */
    private $hydrator;

    /**
     * @var EntityMetadata
     */
    private $metadata;

    /**
     * @var Store
     */
    private $store;

    /**
     * Constructor.
     *
     * @param   EntityMetadata  $metadata
     * @param   Cursor          $cursor
     * @param   Store           $store
     * @param   Hydrator        $hydrator
     */
    public function __construct(EntityMetadata $metadata, Cursor $cursor, Store $store, Hydrator $hydrator)
    {
        $this->metadata = $metadata;
        $this->cursor = $cursor;
        $this->hydrator = $hydrator;
        $this->store = $store;
    }

    /**
     * {@inheritdoc}
     */
    public function count()
    {
        return $this->cursor->count(true);
    }

    /**
     * {@inheritdoc}
     */
    public function current()
    {
        $current = $this->cursor->current();
        return $this->hydrator->normalize($this->metadata, $current, $this->store);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * {@inheritdoc}
     */
    public function key()
    {
        return $this->cursor->key();
    }

    /**
     * {@inheritdoc}
     */
    public function getSingleResult()
    {
        $record = $this->cursor->getSingleResult();
        if (!is_array($record)) {
            return;
        }
        return $this->hydrator->normalize($this->metadata, $record, $this->store);
    }

    /**
     * {@inheritdoc}
     */
    public function next()
    {
        $this->cursor->next();
    }

    /**
     * {@inheritdoc}
     */
    public function rewind()
    {
        $this->cursor->rewind();
    }

    /**
     * {@inheritdoc}
     */
    public function totalCount()
    {
        return $this->cursor->count(false);
    }

    /**
     * {@inheritdoc}
     */
    public function valid()
    {
        return $this->cursor->valid();
    }
}


1			<?php
2
3			namespace As3\Modlr\Persister\MongoDb;
4
5			use As3\Modlr\Metadata\EntityMetadata;
6			use As3\Modlr\Persister\RecordSetInterface;
7			use As3\Modlr\Store\Store;
8			use Doctrine\MongoDB\Cursor;
9
10			/**
11			* Represents records from MongoDb via a Cursor.
12			*
13			* @author Jacob Bare <[email protected]>
14			*/
15			class CursorRecordSet implements RecordSetInterface
16			{
17			/**
18			* @var Cursor
19			*/
20			private $cursor;
21
22			/**
23			* @var Hydrator
24			*/
25			private $hydrator;
26
27			/**
28			* @var EntityMetadata
29			*/
30			private $metadata;
31
32			/**
33			* @var Store
34			*/
35			private $store;
36
37			/**
38			* Constructor.
39			*
40			* @param EntityMetadata $metadata
41			* @param Cursor $cursor
42			* @param Store $store
43			* @param Hydrator $hydrator
44			*/
45			public function __construct(EntityMetadata $metadata, Cursor $cursor, Store $store, Hydrator $hydrator)
46			{
47			$this->metadata = $metadata;
48			$this->cursor = $cursor;
49			$this->hydrator = $hydrator;
50			$this->store = $store;
51			}
52
53			/**
54			* {@inheritdoc}
55			*/
56			public function count()
57			{
58			return $this->cursor->count(true);
59			}
60
61			/**
62			* {@inheritdoc}
63			*/
64			public function current()
65			{
66			$current = $this->cursor->current();
67			return $this->hydrator->normalize($this->metadata, $current, $this->store);
			0 ignored issues – show Bug introduced 2016-09-14 16:24 UTC by Report Bug Copy Issue Report It seems like `$current` defined by `$this->cursor->current()` on line `66` can also be of type `null`; however, `As3\Modlr\Persister\MongoDb\Hydrator::normalize()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
68			}
69
70			/**
71			* {@inheritdoc}
72			*/
73			public function key()
74			{
75			return $this->cursor->key();
76			}
77
78			/**
79			* {@inheritdoc}
80			*/
81			public function getSingleResult()
82			{
83			$record = $this->cursor->getSingleResult();
84			if (!is_array($record)) {
85			return;
86			}
87			return $this->hydrator->normalize($this->metadata, $record, $this->store);
88			}
89
90			/**
91			* {@inheritdoc}
92			*/
93			public function next()
94			{
95			$this->cursor->next();
96			}
97
98			/**
99			* {@inheritdoc}
100			*/
101			public function rewind()
102			{
103			$this->cursor->rewind();
104			}
105
106			/**
107			* {@inheritdoc}
108			*/
109			public function totalCount()
110			{
111			return $this->cursor->count(false);
112			}
113
114			/**
115			* {@inheritdoc}
116			*/
117			public function valid()
118			{
119			return $this->cursor->valid();
120			}
121			}
122

as3io / modlr-persister-mongodb

CursorRecordSet::totalCount() A last analyzed 2016-10-03 17:32 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CursorRecordSet::totalCount() A
last analyzed 2016-10-03 17:32 UTC