As3\Bundle\ModlrBundle\DependencyInjection\ServiceLoader\SearchClients

Complexity

Total Complexity

5

Size/Duplication

Total Lines	56
Duplicated Lines	42.86 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	createElasticClient()	0	16	1
B	load()	24	24	4

<?php

namespace As3\Bundle\ModlrBundle\DependencyInjection\ServiceLoader;

use As3\Bundle\ModlrBundle\DependencyInjection\Utility;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;
use Symfony\Component\DependencyInjection\Reference;

/**
 * Loads search client services.
 *
 * @author  Jacob Bare <jacob.bare@gmail.com>
 */
class SearchClients implements ServiceLoaderInterface
{
    /**
     * Creates the Elastic search client service definition.
     * Will also load support services.
     *
     * @param   string              $clientName
     * @param   array               $clientConfig
     * @param   ContainerBuilder    $container
     * @return  Definition
     */
    private function createElasticClient($clientName, array $clientConfig, ContainerBuilder $container)

The parameter $clientConfig is not used and could be removed.

    {
        // Storage metadata
        $smfName = sprintf('%s.metadata', $clientName);
        $definition = new Definition(
            Utility::getLibraryClass('Search\Elastic\StorageMetadataFactory')
        );
        $definition->setPublic(false);
        $container->setDefinition($smfName, $definition);

        // Client
        return new Definition(
            Utility::getLibraryClass('Search\Elastic\Client'),
            [new Reference($smfName)]
        );
    }

    /**
     * {@inheritdoc}
     */
    public function load(array $config, ContainerBuilder $container)

This method seems to be duplicated in your project.

    {
        $managerDef = $container->getDefinition(Utility::getAliasedName('storage_manager'));

        foreach ($config['search_clients'] as $name => $clientConfig) {
            $clientName = Utility::getAliasedName(sprintf('search_client.%s', $name));
            if (isset($clientConfig['service'])) {
                // Custom search client.
                $container->setAlias($clientName, Utility::cleanServiceName($clientConfig['service']));
            } else {
                // Built-in client.
                switch ($clientConfig['type']) {
                    case 'elastic':
                        $definition = $this->createElasticClient($clientName, $clientConfig, $container);
                        break;
                    default:
                        throw new \RuntimeException(sprintf('The search client type "%s" is currently not supported.', $clientConfig['type']));
                }
                $container->setDefinition($clientName, $definition);
            }
            $managerDef->addMethodCall('addSearchClient', [new Reference($clientName)]);
        }
        return $this;
    }
}