SearchClients   A
last analyzed

Complexity

Total Complexity 5

Size/Duplication

Total Lines 55
Duplicated Lines 43.64 %

Coupling/Cohesion

Components 0
Dependencies 4

Importance

Changes 0
Metric Value
wmc 5
lcom 0
cbo 4
dl 24
loc 55
rs 10
c 0
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
A createElasticClient() 0 16 1
B load() 24 24 4

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace As3\Bundle\ModlrBundle\DependencyInjection\ServiceLoader;
4
5
use As3\Bundle\ModlrBundle\DependencyInjection\Utility;
6
use Symfony\Component\DependencyInjection\ContainerBuilder;
7
use Symfony\Component\DependencyInjection\Definition;
8
use Symfony\Component\DependencyInjection\Reference;
9
10
/**
11
 * Loads search client services.
12
 *
13
 * @author  Jacob Bare <[email protected]>
14
 */
15
class SearchClients implements ServiceLoaderInterface
16
{
17
    /**
18
     * Creates the Elastic search client service definition.
19
     * Will also load support services.
20
     *
21
     * @param   string              $clientName
22
     * @param   ContainerBuilder    $container
23
     * @return  Definition
24
     */
25
    private function createElasticClient($clientName, ContainerBuilder $container)
26
    {
27
        // Storage metadata
28
        $smfName = sprintf('%s.metadata', $clientName);
29
        $definition = new Definition(
30
            Utility::getLibraryClass('Search\Elastic\StorageMetadataFactory')
31
        );
32
        $definition->setPublic(false);
33
        $container->setDefinition($smfName, $definition);
34
35
        // Client
36
        return new Definition(
37
            Utility::getLibraryClass('Search\Elastic\Client'),
38
            [new Reference($smfName)]
39
        );
40
    }
41
42
    /**
43
     * {@inheritdoc}
44
     */
45 View Code Duplication
    public function load(array $config, ContainerBuilder $container)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
46
    {
47
        $managerDef = $container->getDefinition(Utility::getAliasedName('storage_manager'));
48
49
        foreach ($config['search_clients'] as $name => $clientConfig) {
50
            $clientName = Utility::getAliasedName(sprintf('search_client.%s', $name));
51
            if (isset($clientConfig['service'])) {
52
                // Custom search client.
53
                $container->setAlias($clientName, Utility::cleanServiceName($clientConfig['service']));
54
            } else {
55
                // Built-in client.
56
                switch ($clientConfig['type']) {
57
                    case 'elastic':
58
                        $definition = $this->createElasticClient($clientName, $container);
59
                        break;
60
                    default:
61
                        throw new \RuntimeException(sprintf('The search client type "%s" is currently not supported.', $clientConfig['type']));
62
                }
63
                $container->setDefinition($clientName, $definition);
64
            }
65
            $managerDef->addMethodCall('addSearchClient', [new Reference($clientName)]);
66
        }
67
        return $this;
68
    }
69
}
70