App\Http\Controllers\Optimizer

Complexity

Total Complexity

12

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes	3
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	resizepost()	0	25	5
A	resizeremote()	0	21	4
A	getName()	0	11	3

<?php

namespace App\Http\Controllers;

use Approached\LaravelImageOptimizer\ImageOptimizer;
use File;
use GuzzleHttp\Client;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Storage;
use Intervention\Image\Facades\Image;

class Optimizer extends Controller
{

    const EXTENSION_DOT_LENGTH = -4;

    public function resizepost(Request $request, ImageOptimizer $imageOptimizer)
    {
        try {
            $pic = $request->file('picture');
            $width = ($request->get('width')) ? $request->get('width') : 640;
            $height = ($request->get('height')) ? $request->get('height') : null;
            $imageOptimizer->optimizeUploadedImageFile($pic);

It seems like $pic defined by $request->file('picture') on line 20 can also be of type array or null; however, Approached\LaravelImageOptimizer\ImageOptimizer::optimizeUploadedImageFile() does only seem to accept object<Symfony\Component\HttpFoundation\File\UploadedFile>, maybe add an additional type check?

            $newName = substr_replace($pic->getClientOriginalName(),
                $this->getName($width, $height) . '.' . $pic->getClientOriginalExtension(), self::EXTENSION_DOT_LENGTH);
            Storage::put('compressed/' . $newName, File::get($pic));

$pic is of type object<Illuminate\Http\UploadedFile>|array|null, but the function expects a string.

            $img = Image::make(storage_path('app/compressed/') . $newName);
            $resize = $img->resize($width, $height, function ($constraint) {
                $constraint->aspectRatio();
                $constraint->upsize();
            });
            if ($resize) {
                $img->save(storage_path('app/resized/') . $newName);
                unlink(storage_path('app/compressed/') . $newName);
                return $img->response();
            }
        } catch (\Exception $e) {
            return response()->json(['bad_input' => 'The input image is corrupted'], 204);
        }
        return response()->json(['bad_input' => 'The input image is corrupted'], 204);
    }

    public function resizeremote(Request $request, ImageOptimizer $imageOptimizer)
    {
        $pic = $request->get('image');
        $width = ($request->get('width')) ? $request->get('width') : 640;
        $height = ($request->get('height')) ? $request->get('height') : null;
        $file = storage_path('app/remote/') . basename($pic);
        $client = new Client();
        $client->request('GET', $pic, [
            'sink' => storage_path('app/remote/') . basename($pic),
        ]);
        $imageOptimizer->optimizeImage($file);
        $img = Image::make($file);
        $resize = $img->resize($width, $height, function ($constraint) {
            $constraint->aspectRatio();
            $constraint->upsize();
        });
        if ($resize) {
            return $img->response();
        }
        return response()->json(['bad_input' => 'The input image is corrupted']);
    }

    private function getName($w, $h)
    {
        $postfix = '_';
        if ($w) {
            $postfix .= 'w' . $w;
        }
        if ($h) {
            $postfix .= 'h' . $h;
        }
        return $postfix;
    }
}