NinjaMutex\Lock\PredisRedisLock

Complexity

Total Complexity

16

Size/Duplication

Total Lines	148
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Test Coverage

Coverage

73.32%

Importance

Changes	2
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	setExpiration()	0	7	1
A	generateLockInformation()	0	10	2
B	getLock()	0	48	6
A	releaseLock()	0	10	3
A	isLocked()	0	4	1
A	clearLock()	0	9	2

<?php
/**
 * This file is part of ninja-mutex.
 *
 * (C) Kamil Dziedzic <arvenil@klecza.pl>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace NinjaMutex\Lock;

use Predis;

/**
 * Lock implementor using Predis (client library for Redis)
 *
 * @author Kamil Dziedzic <arvenil@klecza.pl>
 */
class PredisRedisLock extends LockAbstract implements LockExpirationInterface
{
    /**
     * Predis connection
     *
     * @var Predis\Client
     */
    protected $client;

    /**
     * @var int Expiration time of the lock in seconds
     */
    protected $expiration = 0;

    /**
     * @param $client Predis\Client
     */
    public function __construct(Predis\Client $client)
    {
        parent::__construct();

        $this->client = $client;
    }

    /**
     * @param int $expiration Expiration time of the lock in seconds
     */
    public function setExpiration($expiration)
    {
        $this->expiration = $expiration;

        // Regenerate the lock information
        $this->lockInformation = $this->generateLockInformation();

The property lockInformation does not seem to exist. Did you mean lockInformationProvider?

    }

    /**
     * @inheritDoc
     */
    protected function generateLockInformation()
    {
        $params = parent::generateLockInformation();

It seems like you code against a specific sub-type and not the parent class NinjaMutex\Lock\LockAbstract as the method generateLockInformation() does only exist in the following sub-classes of NinjaMutex\Lock\LockAbstract: NinjaMutex\Lock\PredisRedisLock. Maybe you want to instanceof check for one of these explicitly?

        if ($this->expiration) {
            $params[] = time() + $this->expiration;
        }

        return $params;
    }

    /**
     * @param  string $name
     * @param  bool   $blocking
     * @return bool
     */
    protected function getLock($name, $blocking)
    {
        /**
         * Perform the process recommended by Redis for acquiring a lock, from here: https://redis.io/commands/setnx
         * We are "C4" in this example...
         *
         * 1. C4 sends SETNX lock.foo in order to acquire the lock (sets the value if it does not already exist).
         * 2. The crashed client C3 still holds it, so Redis will reply with 0 to C4.
         * 3. C4 sends GET lock.foo to check if the lock expired.
         *    If it is not, it will sleep for some time and retry from the start.
         * 4. Instead, if the lock is expired because the Unix time at lock.foo is older than the current Unix time,
         *    C4 tries to perform:
         *    GETSET lock.foo <current Unix timestamp + lock timeout + 1>
         *    Because of the GETSET semantic, C4 can check if the old value stored at key is still an expired timestamp
         *    If it is, the lock was acquired.
         * 5. If another client, for instance C5, was faster than C4 and acquired the lock with the GETSET operation,
         *    the C4 GETSET operation will return a non expired timestamp.
         *    C4 will simply restart from the first step. Note that even if C4 wrote they key and set the expiry time
         *    a few seconds in the future this is not a problem. C5's timeout will just be a few seconds later.
         */

        $lockValue = serialize($this->getLockInformation());

        if ($this->client->setnx($name, $lockValue)) {
            return true;
        }

        // Check if the existing lock has an expiry time. If it does and it has expired, delete the lock.
        if ($existingValue = $this->client->get($name)) {
            $existingValue = unserialize($existingValue);
            if (!empty($existingValue[3]) && $existingValue[3] <= time()) {
                // The existing lock has expired. We can delete it and take over.
                $newExistingValue = unserialize($this->client->getset($name, $lockValue));

                // GETSET atomically sets key to value and returns the old value that was stored at key.
                // If the old value from getset does not still contain an expired timestamp
                // another probably acquired the lock in the meantime.
                if ($newExistingValue[3] > time()) {
                    return false;
                }

                // Got him.
                return true;
            }
        }

        return false;
    }

    /**
     * Release lock
     *
     * @param  string $name name of lock
     * @return bool
     */
    public function releaseLock($name)
    {
        if (isset($this->locks[$name]) && $this->client->del([$name])) {
            unset($this->locks[$name]);

            return true;
        }

        return false;
    }

    /**
     * Check if lock is locked
     *
     * @param  string $name name of lock
     * @return bool
     */
    public function isLocked($name)
    {
        return null !== $this->client->get($name);
    }

    /**
     * Clear lock without releasing it
     * Do not use this method unless you know what you do
     *
     * @param  string $name name of lock
     * @return bool
     */
    public function clearLock($name)
    {
        if (!isset($this->locks[$name])) {
            return false;
        }

        unset($this->locks[$name]);
        return true;
    }
}