Issues in FriendsTest.php (master) - Issues in master - arubacao/friends - Measure and Improve Code Quality continuously with Scrutinizer

Issues (41)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/functional/FriendsTest.php (6 issues)

Labels

Severity

Minor 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * This file is part of Friends.
 *
 * (c) Christopher Lass <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

use Arubacao\Friends\FriendshipStatus;

class FriendsTest extends AbstractTestCase
namespace YourVendor;

class YourClass { }
{
    use \Illuminate\Foundation\Testing\DatabaseTransactions;
//    use \Illuminate\Foundation\Testing\DatabaseMigrations;

    /**
     * @test
     */
    public function a_user_can_send_a_user_a_friend_request() {
        $sender = factory(User::class)->create();
        $recipient = factory(User::class)->create();

        $bool = $sender->sendFriendRequestTo($recipient);

        $this->assertTrue($bool);
        $this->seeInDatabase('friends', [
            'sender_id' => $sender->id,
            'recipient_id' => $recipient->id,
            'friendship_status' => FriendshipStatus::PENDING,
        ]);
        $this->dontSeeInDatabase('friends', [
            'recipient_id' => $sender->id,
            'sender_id' => $recipient->id,
            'friendship_status' => FriendshipStatus::PENDING,
        ]);
        $this->assertCount(1, $sender->any_friends());
        $this->assertCount(1, $recipient->any_friends());
        $this->assertTrue($recipient->hasPendingRequestFrom($sender));
        $this->assertFalse($sender->hasPendingRequestFrom($recipient));
    }

    /**
     * @test
     */
    public function a_user_can_not_send_a_user_a_friend_request_to_himself() {
        $sender = factory(User::class)->create();

        $bool = $sender->sendFriendRequestTo($sender);

        $this->assertFalse($bool);
        $this->dontSeeInDatabase('friends', [
            'recipient_id' => $sender->id,
        ]);
        $this->dontSeeInDatabase('friends', [
            'sender_id' => $sender->id,
        ]);
        $this->assertCount(0, $sender->any_friends());
    }

    /**
     * @test
     */
    public function a_user_can_only_send_one_friend_request_to_a_user() {
        $sender = factory(User::class)->create();
        $recipient = factory(User::class)->create();

        $true = $sender->sendFriendRequestTo($recipient);
        $false1 = $sender->sendFriendRequestTo($recipient);
        $false2 = $sender->sendFriendRequestTo($recipient);
        $false3 = $sender->sendFriendRequestTo($recipient);


        $this->assertTrue($true);
        $this->assertFalse($false1);
        $this->assertFalse($false2);
        $this->assertFalse($false3);
        $this->seeInDatabase('friends', [
            'sender_id' => $sender->id,
            'recipient_id' => $recipient->id,
            'friendship_status' => FriendshipStatus::PENDING,
        ]);
        $this->dontSeeInDatabase('friends', [
            'recipient_id' => $sender->id,
            'sender_id' => $recipient->id,
            'friendship_status' => FriendshipStatus::PENDING,
        ]);
        $this->assertCount(1, $sender->any_friends());
        $this->assertCount(1, $recipient->any_friends());
        $this->assertTrue($recipient->hasPendingRequestFrom($sender));
        $this->assertFalse($sender->hasPendingRequestFrom($recipient));
    }

    /**
     * @test
     */
    public function a_user_can_not_send_a_new_friend_request_to_a_friend() {
        $sender = factory(User::class)->create();
        $recipient = factory(User::class)->create();

        $true1 = $sender->sendFriendRequestTo($recipient);
        $true2 = $recipient->acceptFriendRequestFrom($sender);
        $false = $sender->sendFriendRequestTo($recipient);

        $this->assertTrue($true1);
        $this->assertTrue($true2);
        $this->assertFalse($false);
        $this->seeInDatabase('friends', [
            'sender_id' => $sender->id,
            'recipient_id' => $recipient->id,
            'friendship_status' => FriendshipStatus::ACCEPTED,
        ]);
        $this->dontSeeInDatabase('friends', [
            'sender_id' => $sender->id,
            'recipient_id' => $recipient->id,
            'friendship_status' => FriendshipStatus::PENDING,
        ]);
        $this->assertCount(1, $sender->any_friends());
        $this->assertCount(1, $sender->friends());
        $this->assertCount(1, $recipient->any_friends());
        $this->assertCount(1, $recipient->friends());
        $this->assertFalse($recipient->hasPendingRequestFrom($sender));
        $this->assertFalse($sender->hasPendingRequestFrom($recipient));
    }

    /**
     * @test
     */
    public function a_user_can_not_send_a_new_friend_request_to_a_friend_2() {
        $sender = factory(User::class)->create();
        $recipient = factory(User::class)->create();

        $true1 = $sender->sendFriendRequestTo($recipient);
        $true2 = $recipient->acceptFriendRequestFrom($sender);
        $false = $recipient->sendFriendRequestTo($sender);

        $this->assertTrue($true1);
        $this->assertTrue($true2);
        $this->assertFalse($false);
        $this->seeInDatabase('friends', [
            'sender_id' => $sender->id,
            'recipient_id' => $recipient->id,
            'friendship_status' => FriendshipStatus::ACCEPTED,
        ]);
        $this->dontSeeInDatabase('friends', [
            'sender_id' => $sender->id,
            'recipient_id' => $recipient->id,
            'friendship_status' => FriendshipStatus::PENDING,
        ]);
        $this->dontSeeInDatabase('friends', [
            'sender_id' => $recipient->id,
            'recipient_id' => $sender->id,
            'friendship_status' => FriendshipStatus::PENDING,
        ]);
        $this->assertCount(1, $sender->any_friends());
        $this->assertCount(1, $sender->friends());
        $this->assertCount(1, $recipient->any_friends());
        $this->assertCount(1, $recipient->friends());
        $this->assertFalse($recipient->hasPendingRequestFrom($sender));
        $this->assertFalse($sender->hasPendingRequestFrom($recipient));
    }

    /**
     * @test
     */
    public function a_user_can_delete_a_friend() {
        $sender = factory(User::class)->create();
        $recipient = factory(User::class)->create();

        $sender->sendFriendRequestTo($recipient);
        $recipient->acceptFriendRequestFrom($sender);
        $sender->deleteFriend($recipient);

        $this->dontSeeInDatabase('friends', [
            'sender_id' => $sender->id,
        ]);
        $this->assertCount(0, $sender->any_friends());
        $this->assertCount(0, $recipient->any_friends());
        $this->assertFalse($recipient->isFriendWith($sender));
        $this->assertFalse($sender->isFriendWith($recipient));
    }

    /**
     * @test
     */
    public function a_user_can_accept_a_friend_request() {
        $sender = factory(User::class)->create();
        $recipient = factory(User::class)->create();

        $sender->sendFriendRequestTo($recipient);
        $recipient->acceptFriendRequestFrom($sender);

        $this->seeInDatabase('friends', [
            'sender_id' => $sender->id,
            'recipient_id' => $recipient->id,
            'friendship_status' => FriendshipStatus::ACCEPTED,
        ]);
        $this->dontSeeInDatabase('friends', [
            'sender_id' => $sender->id,
            'recipient_id' => $recipient->id,
            'friendship_status' => FriendshipStatus::PENDING,
        ]);

        $this->assertCount(1, $sender->friends());
        $this->assertCount(1, $recipient->friends());
    }

    /**
     * @test
     */
    public function a_user_is_friend_with_a_user_after_a_friend_request() {
        $sender = factory(User::class)->create();
        $recipient = factory(User::class)->create();

        $sender->sendFriendRequestTo($recipient);
        $recipient->sendFriendRequestTo($sender);

        $this->assertTrue($sender->isFriendWith($recipient));
        $this->assertTrue($recipient->isFriendWith($sender));
    }

    /**
     * @test
     */
    public function a_user_can_deny_a_friend_request() {
        $sender = factory(User::class)->create();
        $recipient = factory(User::class)->create();

        $sender->sendFriendRequestTo($recipient);
        $recipient->denyFriendRequestFrom($sender);

        $this->dontSeeInDatabase('friends', [
            'sender_id' => $sender->id,
        ]);
        $this->dontSeeInDatabase('friends', [
            'recipient_id' => $recipient->id,
        ]);

        $this->assertCount(0, $sender->any_friends());
        $this->assertCount(0, $recipient->any_friends());
    }

    /**
     * @test
     */
    public function a_user_can_not_accept_a_non_existing_friend_request() {
        $sender = factory(User::class)->create();
        $recipient = factory(User::class)->create();

        $bool = $recipient->acceptFriendRequestFrom($sender);

        $this->assertFalse($bool);
        $this->dontSeeInDatabase('friends', [
            'sender_id' => $recipient->id,
            'recipient_id' => $sender->id,
        ]);
        $this->dontSeeInDatabase('friends', [
            'sender_id' => $sender->id,
            'recipient_id' => $recipient->id,
        ]);

        $this->assertCount(0, $sender->friends());
        $this->assertCount(0, $recipient->friends());
        $this->assertCount(0, $sender->any_friends());
        $this->assertCount(0, $recipient->any_friends());
    }

    /**
     * @test
     */
    public function a_friend_request_results_in_a_accepted_if_pending_request_is_available_from_recipient() {
        $sender = factory(User::class)->create();
        $recipient = factory(User::class)->create();

        $sender->sendFriendRequestTo($recipient);
        $recipient->sendFriendRequestTo($sender);

        $this->seeInDatabase('friends', [
            'sender_id' => $sender->id,
            'recipient_id' => $recipient->id,
            'friendship_status' => FriendshipStatus::ACCEPTED,
        ]);
        $this->dontSeeInDatabase('friends', [
            'sender_id' => $sender->id,
            'recipient_id' => $recipient->id,
            'friendship_status' => FriendshipStatus::PENDING,
        ]);
        $this->dontSeeInDatabase('friends', [
            'sender_id' => $recipient->id,
            'recipient_id' => $sender->id,
            'friendship_status' => FriendshipStatus::PENDING,
        ]);

        $this->assertCount(1, $sender->friends());
        $this->assertCount(1, $recipient->friends());
    }

    /**
     * @test
     */
    public function friends_method_returns_empty_array_after_friend_request() {
        $sender = factory(User::class)->create();
        $recipient = factory(User::class)->create();

        $sender->sendFriendRequestTo($recipient);

        $this->assertCount(0, $sender->friends());
        $this->assertCount(0, $recipient->friends());
    }

    /**
     * @test
     */
    public function friends_method_returns_correct_count_of_friends__2_requests_and_2_accepts() {
        $sender = factory(User::class)->create();
        $recipient1 = factory(User::class)->create();
        $recipient2 = factory(User::class)->create();

        $sender->sendFriendRequestTo($recipient1);
        $sender->sendFriendRequestTo($recipient2);
        $recipient1->acceptFriendRequestFrom($sender);
        $recipient2->acceptFriendRequestFrom($sender);

        $this->seeInDatabase('friends', [
            'sender_id' => $sender->id,
            'recipient_id' => $recipient1->id,
            'friendship_status' => FriendshipStatus::ACCEPTED,
        ]);
        $this->seeInDatabase('friends', [
            'sender_id' => $sender->id,
            'recipient_id' => $recipient2->id,
            'friendship_status' => FriendshipStatus::ACCEPTED,
        ]);
        $this->assertCount(2, $sender->friends());
        $this->assertCount(1, $recipient1->friends());
        $this->assertCount(1, $recipient2->friends());
    }

    /**
     * @test
     */
    public function friends_method_returns_correct_count_of_friends__50_requests_and_50_accepts() {
        $sender = factory(User::class)->create();
        $recipients = factory(User::class)->times(50)->create();

        foreach ($recipients as $recipient) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $sender->sendFriendRequestTo($recipient);
            $recipient->acceptFriendRequestFrom($sender);
            $this->assertCount(1, $recipient->friends());
        }

        $this->assertCount(50, $sender->friends());
    }

    /**
     * @test
     */
    public function friends_method_returns_correct_count_of_friends__50_requests_and_25_accepts() {
        $sender = factory(User::class)->create();
        $recipients = factory(User::class)->times(50)->create();

        foreach ($recipients as $key => $recipient) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $sender->sendFriendRequestTo($recipient);
            if ($key % 2) {
                $recipient->acceptFriendRequestFrom($sender);
                $this->assertCount(1, $recipient->friends());
                continue;
            }
            $this->assertCount(0, $recipient->friends());
        }

        $this->assertCount(25, $sender->friends());
    }

    /**
     * @test
     */
    public function friends_method_returns_correct_friends__2_requests_and_2_accepts() {
        $sender = factory(User::class)->create();
        $recipient0 = factory(User::class)->create();
        $recipient1 = factory(User::class)->create();

        $sender->sendFriendRequestTo($recipient0);
        $sender->sendFriendRequestTo($recipient1);
        $recipient0->acceptFriendRequestFrom($sender);
        $recipient1->acceptFriendRequestFrom($sender);

        $this->seeInDatabase('friends', [
            'sender_id' => $sender->id,
            'recipient_id' => $recipient0->id,
            'friendship_status' => FriendshipStatus::ACCEPTED,
        ]);
        $this->seeInDatabase('friends', [
            'sender_id' => $sender->id,
            'recipient_id' => $recipient1->id,
            'friendship_status' => FriendshipStatus::ACCEPTED,
        ]);
        $friends = $sender->friends();
        $this->assertEquals($recipient0->id, $friends[0]->id);
        $this->assertEquals($recipient1->id, $friends[1]->id);
    }

    /**
     * @test
     */
    public function any_friends_method_returns_1_user_after_friend_request() {
        $sender = factory(User::class)->create();
        $recipient = factory(User::class)->create();

        $sender->sendFriendRequestTo($recipient);

        $this->assertCount(1, $sender->any_friends());
        $this->assertCount(1, $recipient->any_friends());
    }

    /**
     * @test
     */
    public function any_friends_method_returns_correct_count_of_any_friends__50_requests_and_25_accepts() {
        $sender = factory(User::class)->create();
        $recipients = factory(User::class)->times(50)->create();

        foreach ($recipients as $key => $recipient) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $sender->sendFriendRequestTo($recipient);
            if ($key % 2) {
                $recipient->acceptFriendRequestFrom($sender);
                $this->assertCount(1, $recipient->any_friends());
                continue;
            }
            $this->assertCount(1, $recipient->any_friends());
        }

        $this->assertCount(50, $sender->any_friends());
    }

    /**
     * @test
     */
    public function any_friends_method_returns_correct_count_of_any_friends__50_requests_and_25_accepts_25_denies() {
        $sender = factory(User::class)->create();
        $recipients = factory(User::class)->times(50)->create();

        foreach ($recipients as $key => $recipient) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $sender->sendFriendRequestTo($recipient);
            if ($key % 2) {
                $recipient->acceptFriendRequestFrom($sender);
                $this->assertCount(1, $recipient->any_friends());
                continue;
            }
            $recipient->denyFriendRequestFrom($sender);
            $this->assertCount(0, $recipient->any_friends());
        }

        $this->assertCount(25, $sender->any_friends());
    }

    /**
     * @test
     */
    public function incoming_friends_method_returns_1_user_after_friend_request() {
        $sender = factory(User::class)->create();
        $recipient = factory(User::class)->create();

        $sender->sendFriendRequestTo($recipient);

        $this->assertCount(0, $sender->incoming_friends());
        $this->assertCount(1, $recipient->incoming_friends());
    }

    /**
     * @test
     */
    public function incoming_friends_method_returns_correct_count_of_any_friends__50_requests_and_25_accepts() {
        $recipient = factory(User::class)->create();
        $senders = factory(User::class)->times(50)->create();

        foreach ($senders as $key => $sender) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $sender->sendFriendRequestTo($recipient);
            if ($key % 2) {
                $recipient->acceptFriendRequestFrom($sender);
                continue;
            }
        }

        $this->assertCount(25, $recipient->incoming_friends());
    }
}

arubacao / friends

Issues (41)

Security Analysis no request data

tests/functional/FriendsTest.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like