arthurkushman / querypath

src/CSS/InputStream.php

<?php
/**
 * @file
 *
 * The CSS Input Stream abstraction.
 */

namespace QueryPath\CSS;

/**
 * Simple wrapper to turn a string into an input stream.
 * This provides a standard interface on top of an array of
 * characters.
 */
class InputStream
{
    protected $stream;
    public $position = 0;

    /**
     * Build a new CSS input stream from a string.
     *
     * @param string
     *  String to turn into an input stream.
     */
    public function __construct($string)
    {
        $this->stream = str_split($string);
    }

    /**
     * Look ahead one character.
     *
     * @return char

The type QueryPath\CSS\char was not found. Maybe you did not declare it correctly or list all dependencies?

     *  Returns the next character, but does not remove it from
     *  the stream.
     */
    public function peek()
    {
        return $this->stream[0];
    }

    /**
     * Get the next unconsumed character in the stream.
     * This will remove that character from the front of the
     * stream and return it.
     */
    public function consume()
    {
        $ret = array_shift($this->stream);

It seems like $this->stream can also be of type boolean; however, parameter $array of array_shift() does only seem to accept array, maybe add an additional type check?

        if (!empty($ret)) {
            $this->position++;
        }

        return $ret;
    }

    /**
     * Check if the stream is empty.
     *
     * @return boolean
     *   Returns TRUE when the stream is empty, FALSE otherwise.
     */
    public function isEmpty()
    {
        return count($this->stream) === 0;

It seems like $this->stream can also be of type boolean; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

    }
}