| Total Complexity | 56 |
| Total Lines | 378 |
| Duplicated Lines | 0 % |
| Changes | 27 | ||
| Bugs | 2 | Features | 0 |
Complex classes like WebSocketServer often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use WebSocketServer, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 19 | class WebSocketServer extends WssMain implements WebSocketServerContract |
||
| 20 | { |
||
| 21 | private const MAX_BYTES_READ = 8192; |
||
| 22 | private const HEADER_BYTES_READ = 1024; |
||
| 23 | |||
| 24 | /** |
||
| 25 | * @var ServerConfig |
||
| 26 | */ |
||
| 27 | protected ServerConfig $config; |
||
| 28 | |||
| 29 | /** |
||
| 30 | * @var array |
||
| 31 | */ |
||
| 32 | private array $clients = []; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * @var array |
||
| 36 | */ |
||
| 37 | private array $headersUpgrade = []; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * @var int |
||
| 41 | */ |
||
| 42 | private int $maxClients = 1; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * @var WebSocket |
||
| 46 | */ |
||
| 47 | private WebSocket $handler; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * @var bool |
||
| 51 | */ |
||
| 52 | private bool $stepRecursion = true; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * @var bool |
||
| 56 | */ |
||
| 57 | private bool $printException = true; |
||
| 58 | |||
| 59 | /** |
||
| 60 | * WebSocketServer constructor. |
||
| 61 | * |
||
| 62 | * @param WebSocket $handler |
||
| 63 | * @param ServerConfig $config |
||
| 64 | */ |
||
| 65 | public function __construct( |
||
| 75 | } |
||
| 76 | |||
| 77 | /** |
||
| 78 | * Configure if error exceptions should be printed |
||
| 79 | * |
||
| 80 | * @return self |
||
| 81 | */ |
||
| 82 | public function printException(bool $printException): self |
||
| 83 | { |
||
| 84 | $this->printException = $printException; |
||
| 85 | |||
| 86 | return $this; |
||
| 87 | } |
||
| 88 | |||
| 89 | /** |
||
| 90 | * Runs main process - Anscestor with server socket on TCP |
||
| 91 | * |
||
| 92 | * @throws WebSocketException |
||
| 93 | * @throws ConnectionException |
||
| 94 | */ |
||
| 95 | public function run(): void |
||
| 126 | } |
||
| 127 | |||
| 128 | /** |
||
| 129 | * Recursive event loop that input intu recusion by remainder = 0 - thus when N users, |
||
| 130 | * and when forks equals true which prevents it from infinite recursive iterations |
||
| 131 | * |
||
| 132 | * @param resource $server server connection |
||
| 133 | * @param bool $fork flag to fork or run event loop |
||
| 134 | * @throws WebSocketException |
||
| 135 | * @throws ConnectionException |
||
| 136 | */ |
||
| 137 | private function eventLoop($server, bool $fork = false): void |
||
| 148 | } |
||
| 149 | } |
||
| 150 | |||
| 151 | /** |
||
| 152 | * @param resource $server |
||
| 153 | * @throws WebSocketException |
||
| 154 | * @throws ConnectionException |
||
| 155 | */ |
||
| 156 | private function looping($server): void |
||
| 157 | { |
||
| 158 | while (true) { |
||
| 159 | $totalClients = count($this->clients) + 1; |
||
| 160 | |||
| 161 | // maxClients prevents process fork on count down |
||
| 162 | if ($totalClients > $this->maxClients) { |
||
| 163 | $this->maxClients = $totalClients; |
||
| 164 | } |
||
| 165 | |||
| 166 | $doFork = $this->config->isForking() === true |
||
| 167 | && $totalClients !== 0 // avoid 0 process creation |
||
| 168 | && $this->stepRecursion === true // only once |
||
| 169 | && $this->maxClients === $totalClients // only if stack grows |
||
| 170 | && $totalClients % $this->config->getClientsPerFork() === 0; // only when N is there |
||
| 171 | if ($doFork) { |
||
| 172 | $this->stepRecursion = false; |
||
| 173 | $this->eventLoop($server, true); |
||
| 174 | } |
||
| 175 | $this->lessConnThanProc($totalClients, $this->maxClients); |
||
| 176 | |||
| 177 | //prepare readable sockets |
||
| 178 | $readSocks = $this->clients; |
||
| 179 | $readSocks[] = $server; |
||
| 180 | $this->cleanSocketResources($readSocks); |
||
| 181 | |||
| 182 | //start reading and use a large timeout |
||
| 183 | if (!stream_select($readSocks, $write, $except, $this->config->getStreamSelectTimeout())) { |
||
| 184 | throw new WebSocketException('something went wrong while selecting', |
||
| 185 | CommonsContract::SERVER_SELECT_ERROR); |
||
| 186 | } |
||
| 187 | |||
| 188 | //new client |
||
| 189 | if (in_array($server, $readSocks, false)) { |
||
| 190 | $this->acceptNewClient($server, $readSocks); |
||
| 191 | if ($this->config->isCheckOrigin() && $this->config->isOriginHeader() === false) { |
||
| 192 | continue; |
||
| 193 | } |
||
| 194 | } |
||
| 195 | |||
| 196 | //message from existing client |
||
| 197 | $this->messagesWorker($readSocks); |
||
| 198 | } |
||
| 199 | } |
||
| 200 | |||
| 201 | /** |
||
| 202 | * @param resource $server |
||
| 203 | * @param array $readSocks |
||
| 204 | * @throws ConnectionException |
||
| 205 | */ |
||
| 206 | private function acceptNewClient($server, array &$readSocks): void |
||
| 241 | } |
||
| 242 | |||
| 243 | /** |
||
| 244 | * @param array $readSocks |
||
| 245 | * @uses onPing |
||
| 246 | * @uses onPong |
||
| 247 | * @uses onMessage |
||
| 248 | */ |
||
| 249 | private function messagesWorker(array $readSocks): void |
||
| 250 | { |
||
| 251 | foreach ($readSocks as $kSock => $sock) { |
||
| 252 | $data = $this->decode(fread($sock, self::MAX_BYTES_READ)); |
||
| 253 | if ($data !== null) { |
||
| 254 | $dataType = null; |
||
| 255 | $dataPayload = null; |
||
| 256 | if ($data !== false) { // payload is too large - waiting for remained data |
||
| 257 | $dataType = $data['type']; |
||
| 258 | $dataPayload = $data['payload']; |
||
| 259 | } |
||
| 260 | |||
| 261 | // to manipulate connection through send/close methods via handler, specified in IConnection |
||
| 262 | $cureentConn = new Connection($sock, $this->clients); |
||
| 263 | if (empty($data) || $dataType === self::EVENT_TYPE_CLOSE) { // close event triggered from client - browser tab or close socket event |
||
| 264 | // trigger CLOSE event |
||
| 265 | try { |
||
| 266 | $this->handler->onClose($cureentConn); |
||
| 267 | } catch (WebSocketException $e) { |
||
| 268 | $this->handleMessagesWorkerException($cureentConn, $e); |
||
| 269 | } |
||
| 270 | |||
| 271 | // to avoid event leaks |
||
| 272 | unset($this->clients[array_search($sock, $this->clients)], $readSocks[$kSock]); |
||
| 273 | continue; |
||
| 274 | } |
||
| 275 | |||
| 276 | $isSupportedMethod = empty(self::MAP_EVENT_TYPE_TO_METHODS[$dataType]) === false |
||
| 277 | && method_exists($this->handler, self::MAP_EVENT_TYPE_TO_METHODS[$dataType]); |
||
| 278 | if ($isSupportedMethod) { |
||
| 279 | try { |
||
| 280 | // dynamic call: onMessage, onPing, onPong |
||
| 281 | $this->handler->{self::MAP_EVENT_TYPE_TO_METHODS[$dataType]}($cureentConn, $dataPayload); |
||
| 282 | } catch (WebSocketException $e) { |
||
| 283 | $this->handleMessagesWorkerException($cureentConn, $e); |
||
| 284 | } |
||
| 285 | } |
||
| 286 | } |
||
| 287 | } |
||
| 288 | } |
||
| 289 | |||
| 290 | /** |
||
| 291 | * Handshakes/upgrade and key parse |
||
| 292 | * |
||
| 293 | * @param resource $client Source client socket to write |
||
| 294 | * @param string $headers Headers that client has been sent |
||
| 295 | * @return string socket handshake key (Sec-WebSocket-Key)| false on parse error |
||
| 296 | * @throws ConnectionException |
||
| 297 | */ |
||
| 298 | private function handshake($client, string $headers): string |
||
| 299 | { |
||
| 300 | $match = []; |
||
| 301 | preg_match(self::SEC_WEBSOCKET_KEY_PTRN, $headers, $match); |
||
| 302 | if (empty($match[1])) { |
||
| 303 | return ''; |
||
| 304 | } |
||
| 305 | |||
| 306 | $key = $match[1]; |
||
| 307 | // sending header according to WebSocket Protocol |
||
| 308 | $secWebSocketAccept = base64_encode(sha1(trim($key) . self::HEADER_WEBSOCKET_ACCEPT_HASH, true)); |
||
| 309 | $this->setHeadersUpgrade($secWebSocketAccept); |
||
| 310 | $upgradeHeaders = $this->getHeadersUpgrade(); |
||
| 311 | |||
| 312 | fwrite($client, $upgradeHeaders); |
||
| 313 | |||
| 314 | return $key; |
||
| 315 | } |
||
| 316 | |||
| 317 | /** |
||
| 318 | * Sets an array of headers needed to upgrade server/client connection |
||
| 319 | * |
||
| 320 | * @param string $secWebSocketAccept base64 encoded Sec-WebSocket-Accept header |
||
| 321 | */ |
||
| 322 | private function setHeadersUpgrade(string $secWebSocketAccept): void |
||
| 323 | { |
||
| 324 | $this->headersUpgrade = [ |
||
| 325 | self::HEADERS_UPGRADE_KEY => self::HEADERS_UPGRADE_VALUE, |
||
| 326 | self::HEADERS_CONNECTION_KEY => self::HEADERS_CONNECTION_VALUE, |
||
| 327 | self::HEADERS_SEC_WEBSOCKET_ACCEPT_KEY => ' ' . $secWebSocketAccept |
||
| 328 | // the space before key is really important |
||
| 329 | ]; |
||
| 330 | } |
||
| 331 | |||
| 332 | /** |
||
| 333 | * Retreives headers from an array of headers to upgrade server/client connection |
||
| 334 | * |
||
| 335 | * @return string Headers to Upgrade communication connection |
||
| 336 | * @throws ConnectionException |
||
| 337 | */ |
||
| 338 | private function getHeadersUpgrade(): string |
||
| 339 | { |
||
| 340 | $handShakeHeaders = self::HEADER_HTTP1_1 . self::HEADERS_EOL; |
||
| 341 | if (empty($this->headersUpgrade)) { |
||
| 342 | throw new ConnectionException('Headers for upgrade handshake are not set' . PHP_EOL, |
||
| 343 | CommonsContract::SERVER_HEADERS_NOT_SET); |
||
| 344 | } |
||
| 345 | |||
| 346 | foreach ($this->headersUpgrade as $key => $header) { |
||
| 347 | $handShakeHeaders .= $key . ':' . $header . self::HEADERS_EOL; |
||
| 348 | if ($key === self::HEADERS_SEC_WEBSOCKET_ACCEPT_KEY) { // add additional EOL fo Sec-WebSocket-Accept |
||
| 349 | $handShakeHeaders .= self::HEADERS_EOL; |
||
| 350 | } |
||
| 351 | } |
||
| 352 | |||
| 353 | return $handShakeHeaders; |
||
| 354 | } |
||
| 355 | |||
| 356 | /** |
||
| 357 | * Parses parameters from GET on web-socket client connection before handshake |
||
| 358 | * |
||
| 359 | * @param string $headers |
||
| 360 | */ |
||
| 361 | private function setPathParams(string $headers): void |
||
| 381 | } |
||
| 382 | } |
||
| 383 | } |
||
| 384 | |||
| 385 | /** |
||
| 386 | * Manage messagesWorker Exceptions |
||
| 387 | * |
||
| 388 | * @param Connection $connection |
||
| 389 | * @param WebSocketException $e |
||
| 390 | */ |
||
| 391 | private function handleMessagesWorkerException(Connection $connection, WebSocketException $e): void |
||
| 397 | } |
||
| 398 | } |
||
| 399 | } |
||
| 400 |
If you suppress an error, we recommend checking for the error condition explicitly: