artem-prozorov / repos

src/Resolvers/ContainerAwareResolver.php

<?php

declare(strict_types=1);

namespace Prozorov\Repositories\Resolvers;

use Prozorov\Repositories\Contracts\{RepositoryInterface, ResolverInterface};
use Prozorov\Repositories\Exceptions\CouldNotResolve;
use Psr\Container\{ContainerInterface, ContainerExceptionInterface};

class ContainerAwareResolver implements ResolverInterface
{
    /**
     * @var ContainerInterface $container
     */
    protected $container;

    public function __construct(ContainerInterface $container)
    {
        $this->container = $container;
    }

    /**
     * @inheritDoc
     */
    public function resolve(string $className): RepositoryInterface
    {
        try {
            $resolved = $this->container->get($className);

            if (! ($resolved instanceof RepositoryInterface)) {
                $class = get_class($resolved);

                $message = $class . ' does not implements RepositoryInterface. Refer to documentation';
                $this->fail($className, $message);
            }

            return $resolved;
        } catch (ContainerExceptionInterface $exception) {
            $this->fail($className, $exception->getMessage());

The method getMessage() does not exist on Psr\Container\ContainerExceptionInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Psr\Container\NotFoundExceptionInterface. Are you sure you never get one of those?

In this branch, the function will implicitly return null which is incompatible with the type-hinted return Prozorov\Repositories\Contracts\RepositoryInterface. Consider adding a return statement or allowing null as return value.

        }
    }

    /**
     * fail.
     *
     * @access    protected
     * @param string $className
     * @param string $message
     * @return    void
     */
    protected function fail(string $className, string $message = ''): void
    {
        $exception = new CouldNotResolve($message);
        $exception->setRepositoryCode($className);

        throw $exception;
    }
}