Issues (7)

src/AbstractRepository.php (2 issues)

Labels
Severity
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Prozorov\Repositories;
6
7
use Prozorov\Repositories\Contracts\RepositoryInterface;
8
use Prozorov\Repositories\{Query, Result};
0 ignored issues
show
This use statement conflicts with another class in this namespace, Prozorov\Repositories\Query. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
The type Prozorov\Repositories\Result was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
9
use Prozorov\Repositories\Exceptions\DataNotFound;
10
use Prozorov\Repositories\Exceptions\NotImplemented;
11
12
abstract class AbstractRepository extends FixturableRepository
13
{
14
    abstract protected function doGet($params): ?iterable;
15
16
    abstract protected function doFirst(array $filter);
17
18
    abstract protected function doGetById(int $id, array $select = null);
19
20
    abstract protected function doGetByIdOrFail(int $id, array $select = null);
21
22
    abstract protected function doCreate(array $data);
23
24
    abstract protected function doUpdate($model, array $data): void;
25
26
    abstract protected function doDelete($model): void;
27
28
    abstract protected function doExists(array $filter): bool;
29
30
    abstract protected function doCount(array $filter = []): int;
31
32
    abstract protected function doOpenTransaction(): void;
33
34
    abstract protected function doCommitTransaction(): void;
35
36
    abstract protected function doRollbackTransaction(): void;
37
}
38